[jira] [Commented] (NIFI-13679) NIFI CLI create-reg-client should be capable of handling GitHubFlowRegistryClient

["Bryan Bende (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-13679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17876780#comment-17876780 ] 

Bryan Bende commented on NIFI-13679:
------------------------------------

I think the command likely existed before registry clients were an extension point, so the only kind of client was a NiFi Registry client with a single property for URL.

Since the properties can now be arbitrary for any given client implementation, we probably want to consider allowing the command to accept a json object as input which contains the registry client entity. We have similar examples for create-controller-service and create-reporting-task I think.

> NIFI CLI create-reg-client should be capable of handling GitHubFlowRegistryClient
> ---------------------------------------------------------------------------------
>
>                 Key: NIFI-13679
>                 URL: https://issues.apache.org/jira/browse/NIFI-13679
>             Project: Apache NiFi
>          Issue Type: Improvement
>         Environment: Official Docker Images 2.0.0-M4 (NiFi, NiFi Registry, NiFi Toolkit) running on Ubuntu 22.04.4 LTS and Docker v27.0.3
>            Reporter: Julien Ledoux
>            Priority: Major
>
> This ticket concerns the {{bin/cli.sh nifi create-reg-client}} and {{update-reg-client}} commands.
> While attempting to automate the provisioning of NifiRegistryFlowRegistryClient(s) and GitHubFlowRegistryClient(s), I noticed that the available options in the NiFi CLI do not fully support the necessary configurations for GitHub.
> I tried using the {{--properties}} option to see if I could create a {{GitHubFlowRegistryClient}} this way. While it is possible to change the registry client type to {{{}GitHubFlowRegistryClient{}}}, the CLI doesn't allow configuring all the specific properties—only those it shares with {{{}NifiRegistryFlowRegistryClient{}}}.
> It would be highly beneficial to have the ability to manage this type of registry client in the same way as {{{}NifiRegistryFlowRegistryClient{}}}.
> It seems that the DTO object does support all the GitHub-specific properties, but the command currently only passes four properties to the DTO: name, description, type, and URL.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)