You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/09/18 06:16:41 UTC

[GitHub] [kafka] dengziming opened a new pull request #11339: MINOR: ClientQuotaRecord is ignored in MetadataShell

dengziming opened a new pull request #11339:
URL: https://github.com/apache/kafka/pull/11339


   *More detailed description of your change*
   In KRaft mode, I updated client quota and inspected using MetadataShell:
   ```
   ConfigCommand --entity-type users --entity-name dengziming --bootstrap-server localhost:9092 --alter --add-config producer_byte_rate=1000
   
   [ Kafka Metadata Shell ]
   >> ls /configs/user/
   ls: /configs/user/: no such file or directory.
   ```
   
   After this change, the config is rightly presented using MetadataShell:
   ```
   cat /configs/user/dengziming/producer_byte_rate
   1000.0
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe commented on pull request #11339: MINOR: ClientQuotaRecord is not handled in KRaft MetadataShell

Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #11339:
URL: https://github.com/apache/kafka/pull/11339#issuecomment-952318773


   I followed https://github.com/apache/kafka/pull/11437 to fix up the path that we're using. These shouldn't actually be in the config directory (because they're not configs)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe edited a comment on pull request #11339: MINOR: ClientQuotaRecord is not handled in KRaft MetadataShell

Posted by GitBox <gi...@apache.org>.
cmccabe edited a comment on pull request #11339:
URL: https://github.com/apache/kafka/pull/11339#issuecomment-952318773


   I filed https://github.com/apache/kafka/pull/11437 to fix up the path that we're using. These shouldn't actually be in the config directory (because they're not configs)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe commented on pull request #11339: MINOR: ClientQuotaRecord is not handled in KRaft MetadataShell

Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #11339:
URL: https://github.com/apache/kafka/pull/11339#issuecomment-952276357


   @dengziming : thanks for this! I'm sorry that I've been so slow to review things lately... too much work piled up. I think it looks good. I especially liked that you added `MetadataNodeManagerTest.java`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe commented on pull request #11339: MINOR: ClientQuotaRecord is not handled in KRaft MetadataShell

Posted by GitBox <gi...@apache.org>.
cmccabe commented on pull request #11339:
URL: https://github.com/apache/kafka/pull/11339#issuecomment-952292489


   I re-ran SaslPlainSslEndToEndAuthorizationTest and LeaderElectionCommandTest locally and they both passed. These tests are known to be flaky and the failure is not caused by this PR. Committing, thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] cmccabe merged pull request #11339: MINOR: ClientQuotaRecord is not handled in KRaft MetadataShell

Posted by GitBox <gi...@apache.org>.
cmccabe merged pull request #11339:
URL: https://github.com/apache/kafka/pull/11339


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dengziming commented on pull request #11339: MINOR: ClientQuotaRecord is not handled in KRaft MetadataShell

Posted by GitBox <gi...@apache.org>.
dengziming commented on pull request #11339:
URL: https://github.com/apache/kafka/pull/11339#issuecomment-924890352


   Hello, @cmccabe @mumrah PTAL. thank you 🤝.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org