[GitHub] [nuttx-apps] pkarashchenko commented on a diff in pull request #1649: Add another batch of missing headers throughout the repository

["pkarashchenko (via GitHub)" <gi...@apache.org>]

pkarashchenko commented on code in PR #1649:
URL: https://github.com/apache/nuttx-apps/pull/1649#discussion_r1130183918


##########
testing/ostest/suspend.c:
##########
@@ -22,14 +22,18 @@
  * Included Files
  ****************************************************************************/
 
-#include <sys/types.h>
+#include <nuttx/config.h>
+
+#include <errno.h>
+#include <pthread.h>
+#include <sched.h>
+#include <semaphore.h>
+#include <signal.h>
 #include <stdbool.h>
 #include <stdio.h>
 #include <unistd.h>
-#include <semaphore.h>
-#include <signal.h>
-#include <sched.h>
-#include <errno.h>
+#include <sys/types.h>

Review Comment:
   Do we really need this include? I think sys/types.h is included in most of the standard headers above. What specific type used here needs this explicit include?
   And same question in other similar places



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org