You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Cody Maloney <co...@mesosphere.io> on 2014/10/15 03:29:33 UTC

Review Request 26724: Remove --without-cxx11 flag

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26724/
-----------------------------------------------------------

Review request for mesos and Dominic Hamon.


Repository: mesos-git


Description
-------

C++11 is required now. Specifying this flag makes no change in the actual compilation of mesos.


Diffs
-----

  configure.ac 2b372e06006250b5230956ef096473e98f3fa590 

Diff: https://reviews.apache.org/r/26724/diff/


Testing
-------

grep -r 'with_cxx11' in the mesos repository


Thanks,

Cody Maloney


Re: Review Request 26724: Remove --without-cxx11 flag

Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26724/#review56724
-----------------------------------------------------------

Ship it!


Ship It!

- Dominic Hamon


On Oct. 15, 2014, 9:49 a.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26724/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 9:49 a.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Bugs: MESOS-750
>     https://issues.apache.org/jira/browse/MESOS-750
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> C++11 is required now. Specifying this flag makes no change in the actual compilation of mesos.
> 
> 
> Diffs
> -----
> 
>   configure.ac 2b372e06006250b5230956ef096473e98f3fa590 
> 
> Diff: https://reviews.apache.org/r/26724/diff/
> 
> 
> Testing
> -------
> 
> grep -r 'with_cxx11' in the mesos repository
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>


Re: Review Request 26724: Remove --without-cxx11 flag

Posted by Cody Maloney <co...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26724/
-----------------------------------------------------------

(Updated Oct. 15, 2014, 4:49 p.m.)


Review request for mesos and Dominic Hamon.


Bugs: MESOS-750
    https://issues.apache.org/jira/browse/MESOS-750


Repository: mesos-git


Description
-------

C++11 is required now. Specifying this flag makes no change in the actual compilation of mesos.


Diffs
-----

  configure.ac 2b372e06006250b5230956ef096473e98f3fa590 

Diff: https://reviews.apache.org/r/26724/diff/


Testing
-------

grep -r 'with_cxx11' in the mesos repository


Thanks,

Cody Maloney


Re: Review Request 26724: Remove --without-cxx11 flag

Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26724/#review56653
-----------------------------------------------------------


Patch looks great!

Reviews applied: [26724]

All tests passed.

- Mesos ReviewBot


On Oct. 15, 2014, 1:29 a.m., Cody Maloney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26724/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2014, 1:29 a.m.)
> 
> 
> Review request for mesos and Dominic Hamon.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> C++11 is required now. Specifying this flag makes no change in the actual compilation of mesos.
> 
> 
> Diffs
> -----
> 
>   configure.ac 2b372e06006250b5230956ef096473e98f3fa590 
> 
> Diff: https://reviews.apache.org/r/26724/diff/
> 
> 
> Testing
> -------
> 
> grep -r 'with_cxx11' in the mesos repository
> 
> 
> Thanks,
> 
> Cody Maloney
> 
>