You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/02/04 15:27:05 UTC
[GitHub] [incubator-apisix] agile6v opened a new issue #1106: request help:
The configuration of the config.yaml file is a bit confusing.
agile6v opened a new issue #1106: request help: The configuration of the config.yaml file is a bit confusing.
URL: https://github.com/apache/incubator-apisix/issues/1106
Hi,
I want to add proxy_protocol flag in this file for http block and stream block seperately. But I'm not sure where to put it.
Flags look like below:
enable_http_proxy_protocol (for receive from client)
enable_tcp_proxy_protocol (for receive from client)
enable_tcp_proxy_protocol_to_upstream (for sending proxy_protocol to upstream)
Do you have any good suggestions?
Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis edited a comment on issue #1106:
request help: The configuration of the config.yaml file is a bit confusing.
Posted by GitBox <gi...@apache.org>.
membphis edited a comment on issue #1106: request help: The configuration of the config.yaml file is a bit confusing.
URL: https://github.com/apache/incubator-apisix/issues/1106#issuecomment-582285413
> According to the current classification, `real_ip_header` and `real_ip_from` should be placed in `nginx_config.http`.
>
your way is better ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] agile6v commented on issue #1106: request help:
The configuration of the config.yaml file is a bit confusing.
Posted by GitBox <gi...@apache.org>.
agile6v commented on issue #1106: request help: The configuration of the config.yaml file is a bit confusing.
URL: https://github.com/apache/incubator-apisix/issues/1106#issuecomment-581985581
According to the current classification, `real_ip_header` and `real_ip_from` should be placed in `nginx_config.http`.
I would prefer to use the following way.
```yaml
nginx_config: # config for render the template to genarate nginx.conf
error_log: "logs/error.log"
error_log_level: "warn" # warn,error
event:
worker_connections: 10620
http:
real_ip_header: "X-Real-IP"
real_ip_from:
- 127.0.0.1
- 'unix:'
access_log: "logs/access.log"
keepalive_timeout: 60s # timeout during which a keep-alive client connection will stay open on the server side.
client_header_timeout: 60s # timeout for reading client request header, then 408 (Request Time-out) error is returned to the client
client_body_timeout: 60s # timeout for reading client request body, then 408 (Request Time-out) error is returned to the client
send_timeout: 10s # timeout for transmitting a response to the client.then the connection is closed
stream:
proxy_protocol: true
proxy_protocol_to_upstream: true
tcp:
- 9100
- 9101
udp:
- 9200
- 9211
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] membphis commented on issue #1106: request help:
The configuration of the config.yaml file is a bit confusing.
Posted by GitBox <gi...@apache.org>.
membphis commented on issue #1106: request help: The configuration of the config.yaml file is a bit confusing.
URL: https://github.com/apache/incubator-apisix/issues/1106#issuecomment-582285413
> According to the current classification, `real_ip_header` and `real_ip_from` should be placed in `nginx_config.http`.
>
this way is better ^_^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming commented on issue #1106: request help:
The configuration of the config.yaml file is a bit confusing.
Posted by GitBox <gi...@apache.org>.
moonming commented on issue #1106: request help: The configuration of the config.yaml file is a bit confusing.
URL: https://github.com/apache/incubator-apisix/issues/1106#issuecomment-582309937
> According to the current classification, `real_ip_header` and `real_ip_from` should be placed in `nginx_config.http`.
>
> I would prefer to use the following way.
>
> ```yaml
> nginx_config: # config for render the template to genarate nginx.conf
> error_log: "logs/error.log"
> error_log_level: "warn" # warn,error
> event:
> worker_connections: 10620
> http:
> real_ip_header: "X-Real-IP"
> real_ip_from:
> - 127.0.0.1
> - 'unix:'
> access_log: "logs/access.log"
> keepalive_timeout: 60s # timeout during which a keep-alive client connection will stay open on the server side.
> client_header_timeout: 60s # timeout for reading client request header, then 408 (Request Time-out) error is returned to the client
> client_body_timeout: 60s # timeout for reading client request body, then 408 (Request Time-out) error is returned to the client
> send_timeout: 10s # timeout for transmitting a response to the client.then the connection is closed
> stream:
> proxy_protocol: true
> proxy_protocol_to_upstream: true
> tcp:
> - 9100
> - 9101
> udp:
> - 9200
> - 9211
> ```
I don't think so. `nginx_config` is a hacky way, Apache APISIX should hide these Nginx configurations finally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-apisix] moonming closed issue #1106: request help: The
configuration of the config.yaml file is a bit confusing.
Posted by GitBox <gi...@apache.org>.
moonming closed issue #1106: request help: The configuration of the config.yaml file is a bit confusing.
URL: https://github.com/apache/incubator-apisix/issues/1106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services