You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Robert Muir (JIRA)" <ji...@apache.org> on 2010/07/20 00:22:51 UTC
[jira] Created: (LUCENE-2551) change jdk & icu collation to use
byte[]
change jdk & icu collation to use byte[]
----------------------------------------
Key: LUCENE-2551
URL: https://issues.apache.org/jira/browse/LUCENE-2551
Project: Lucene - Java
Issue Type: Improvement
Components: contrib/analyzers
Reporter: Robert Muir
Priority: Minor
Fix For: 4.0
Attachments: LUCENE-2551.patch
Now that term is byte[], we should switch collation to use byte[] instead of 'indexablebinarystring'.
This is faster and results in much smaller sort keys.
I figure we can work it out here, and fix termrangequery to use byte in parallel, but we can already test sorting etc now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Commented: (LUCENE-2551) change jdk & icu collation to use
byte[]
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12890260#action_12890260 ]
Robert Muir commented on LUCENE-2551:
-------------------------------------
I looked at some of the keys in the test code, and encoding directly as byte results in keys nearly 1/2 the size (in bytes) of the previous encoding.
> change jdk & icu collation to use byte[]
> ----------------------------------------
>
> Key: LUCENE-2551
> URL: https://issues.apache.org/jira/browse/LUCENE-2551
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/analyzers
> Reporter: Robert Muir
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2551.patch, LUCENE-2551.patch
>
>
> Now that term is byte[], we should switch collation to use byte[] instead of 'indexablebinarystring'.
> This is faster and results in much smaller sort keys.
> I figure we can work it out here, and fix termrangequery to use byte in parallel, but we can already test sorting etc now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2551) change jdk & icu collation to use
byte[]
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2551:
--------------------------------
Attachment: LUCENE-2551.patch
Updated patch, with javadocs, and attributefactory violations corrected.
I think this patch is ready, but we should probably fix a few things (TermRangeQuery, QueryParser should consume with BytesRef not string) first.
> change jdk & icu collation to use byte[]
> ----------------------------------------
>
> Key: LUCENE-2551
> URL: https://issues.apache.org/jira/browse/LUCENE-2551
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/analyzers
> Reporter: Robert Muir
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2551.patch, LUCENE-2551.patch
>
>
> Now that term is byte[], we should switch collation to use byte[] instead of 'indexablebinarystring'.
> This is faster and results in much smaller sort keys.
> I figure we can work it out here, and fix termrangequery to use byte in parallel, but we can already test sorting etc now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] Updated: (LUCENE-2551) change jdk & icu collation to use
byte[]
Posted by "Robert Muir (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/LUCENE-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Muir updated LUCENE-2551:
--------------------------------
Attachment: LUCENE-2551.patch
attached is a quick prototype.
I kept the old representation working via Version. if you use >= 4.0, it just encodes to byte.
I figure this has enough violations that Uwe will jump in and help :)
> change jdk & icu collation to use byte[]
> ----------------------------------------
>
> Key: LUCENE-2551
> URL: https://issues.apache.org/jira/browse/LUCENE-2551
> Project: Lucene - Java
> Issue Type: Improvement
> Components: contrib/analyzers
> Reporter: Robert Muir
> Priority: Minor
> Fix For: 4.0
>
> Attachments: LUCENE-2551.patch
>
>
> Now that term is byte[], we should switch collation to use byte[] instead of 'indexablebinarystring'.
> This is faster and results in much smaller sort keys.
> I figure we can work it out here, and fix termrangequery to use byte in parallel, but we can already test sorting etc now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org