[GitHub] [curator] jmslocum16 commented on pull request #376: CURATOR-584: WIP: Starting with foreground idempotent create

[GitBox <gi...@apache.org>]

jmslocum16 commented on pull request #376:
URL: https://github.com/apache/curator/pull/376#issuecomment-745344702


   > @jmslocum16 the basic interface looks OK to me, as does the idempotent logic.
   > 
   > Just to confirm my understanding of your solution, your plan is to still have the connection loss exception propagate up to the client code, and they will retry create / update commands with the idempotent flag set, which will succeed if the versions / data match?
   
   Hi Cam, thanks for the quick response!
   I'm glad I submitted this patch early - having the client retry was actually not the intended behavior. I had assumed the retry loop inside pathInForeground would handle retrying upon connection loss. It sounds like my assumptions were not correct there and i need to dig more into how retrying works, to make sure the client doesn't have to explicitly retry, and write some tests to validate that behavior.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org