You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2020/04/24 07:42:52 UTC
[GitHub] [incubator-echarts] linssen opened a new issue #12489: Improve theme documentation
linssen opened a new issue #12489:
URL: https://github.com/apache/incubator-echarts/issues/12489
### What problem does this feature solve?
It's unclear what attributes you may add to a theme to affect the layout of a chart. The example themes don't list every available option, and not all chart options may be altered via the theme.
### What does the proposed API look like?
I'd propose adding the following to the docs:
1. All chart options that may be set from a theme
1. The precedence in which these options are applied (theme < init opts < setOption) etc.
1. Specific options which may _not_ be set via a theme
1. Add all available options to a starter theme, perhaps the light / dark ones, to download as a template
<!-- This issue is generated by echarts-issue-helper. DO NOT REMOVE -->
<!-- This issue is in English. DO NOT REMOVE -->
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #12489: Improve theme documentation
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #12489:
URL: https://github.com/apache/incubator-echarts/issues/12489#issuecomment-643185207
Hi @linssen, sorry for the late reply.
The configuration of the theme is very similar to the option. The only difference is series in theme is described in a map.
For example:
A typical option is :
```js
option = {
series: [{
type: 'bar',
itemStyle: { color: }
}]
}
```
In theme, it needs to be:
```js
theme = {
bar: {
itemStyle: { color: }
}
}
```
Besides this tiny difference, all the configurations in option can be described in theme, it will override the default value provided by echarts. Also, it can be override by the user option.
PS: @Ovilia did a visual theme builder. But currently, the UI is still in Chinese. https://www.echartsjs.com/theme-builder/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang commented on issue #12489: Improve theme documentation
Posted by GitBox <gi...@apache.org>.
pissang commented on issue #12489:
URL: https://github.com/apache/incubator-echarts/issues/12489#issuecomment-618985230
Indeed, thanks for the suggestion!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] linssen commented on issue #12489: Improve theme documentation
Posted by GitBox <gi...@apache.org>.
linssen commented on issue #12489:
URL: https://github.com/apache/incubator-echarts/issues/12489#issuecomment-619091526
I'd be more than happy to help with the en side if I had a list of things 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] pissang edited a comment on issue #12489: Improve theme documentation
Posted by GitBox <gi...@apache.org>.
pissang edited a comment on issue #12489:
URL: https://github.com/apache/incubator-echarts/issues/12489#issuecomment-643185207
Hi @linssen, sorry for the late reply.
The configuration of the theme is very similar to the option. The only difference is series in theme is described in a map.
For example:
A typical option is :
```js
option = {
series: [{
type: 'bar',
itemStyle: { color: }
}]
}
```
In theme, it needs to be:
```js
theme = {
bar: {
itemStyle: { color: }
}
}
```
Besides this tiny difference, all the configurations in option can be described in theme, it will override the default value provided by echarts. Also, it can be override by the user option.
PS: @Ovilia did a visual theme builder https://www.echartsjs.com/theme-builder/. But currently, the UI is still in Chinese.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] echarts-bot[bot] commented on issue #12489: Improve theme documentation
Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #12489:
URL: https://github.com/apache/incubator-echarts/issues/12489#issuecomment-618857940
Hi! We've received your issue and please be patient to get responded. 🎉
The average response time is expected to be within one day for weekdays.
In the meanwhile, please make sure that **you have posted enough image to demo your request**. You may also check out the [API](http://echarts.apache.org/api.html) and [chart option](http://echarts.apache.org/option.html) to get the answer.
If you don't get helped for a long time (over a week) or have an urgent question to ask, you may also send an email to dev@echarts.apache.org. Please attach the issue link if it's a technical questions.
If you are interested in the project, you may also subscribe our [mail list](https://echarts.apache.org/en/maillist.html).
Have a nice day! 🍵
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org
[GitHub] [incubator-echarts] tbtalbottjr commented on issue #12489: Improve theme documentation
Posted by GitBox <gi...@apache.org>.
tbtalbottjr commented on issue #12489:
URL: https://github.com/apache/incubator-echarts/issues/12489#issuecomment-673696020
@pissang Your comment is the most helpful bit of information I've found so far. It would be quite helpful for this to be part of the API documentation. But at least I have an idea of how to proceed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org