You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/11/29 23:30:41 UTC
[GitHub] [beam] htyleo opened a new pull request, #24421: [#24419] Support composite output types in sql.Transform.
htyleo opened a new pull request, #24421:
URL: https://github.com/apache/beam/pull/24421
Support composite output types in sql.Transform.
R: @lostluck
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] htyleo commented on pull request #24421: [#24419] Support composite output types in sql.Transform.
Posted by GitBox <gi...@apache.org>.
htyleo commented on PR #24421:
URL: https://github.com/apache/beam/pull/24421#issuecomment-1331519801
> > > Technically a breaking change, but only for uses we don't support anyway.
> >
> >
> > I thought this isn't a breaking change, since we are just adding an optional, variadic param?
>
> Turns out that Go has no safe type changes one can make to Exported identifiers.
>
> `OutputType` has a function type of `func(t reflect.Type)`, which means we could previously assign it to a `var foo func(reflect.Type)` if we wanted. That would fail now because you can't assign a `func(reflect.Type, ... typex.FullType)` to `func(reflect.Type)`.
>
> Since this isn't a pattern we advocate for or demo, it's acceptable in my view, even though it can break a compile for someone. In this case, it's very obvious that something is broken and that the fix is generally pretty obvious.
Ar, gotcha. Thanks for the detailed explanation!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] htyleo commented on pull request #24421: [#24419] Support composite output types in sql.Transform.
Posted by GitBox <gi...@apache.org>.
htyleo commented on PR #24421:
URL: https://github.com/apache/beam/pull/24421#issuecomment-1331480383
> Technically a breaking change, but only for uses we don't support anyway.
I thought this isn't a breaking change, since we are just adding an optional, variadic param?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck merged pull request #24421: [#24419] Support composite output types in sql.Transform.
Posted by GitBox <gi...@apache.org>.
lostluck merged PR #24421:
URL: https://github.com/apache/beam/pull/24421
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #24421: [#24419] Support composite output types in sql.Transform.
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #24421:
URL: https://github.com/apache/beam/pull/24421#issuecomment-1331496654
> > Technically a breaking change, but only for uses we don't support anyway.
>
> I thought this isn't a breaking change, since we are just adding an optional, variadic param?
Turns out that Go has no safe type changes one can make to Exported identifiers.
`OutputType` has a function type of `func(t reflect.Type)`, which means we could previously assign it to a `var foo func(reflect.Type)` if we wanted. That would fail now because you can't assign a `func(reflect.Type, ... typex.FullType)` to `func(reflect.Type)`.
Since this isn't a pattern we advocate for or demo, it's acceptable in my view, even though it can break a compile for someone. In this case, it's very obvious that something is broken and that the fix is generally pretty obvious.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #24421: [#24419] Support composite output types in sql.Transform.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #24421:
URL: https://github.com/apache/beam/pull/24421#issuecomment-1331455675
# [Codecov](https://codecov.io/gh/apache/beam/pull/24421?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24421](https://codecov.io/gh/apache/beam/pull/24421?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (90e01c9) into [master](https://codecov.io/gh/apache/beam/commit/1335b98ce54a08fcf0f274e0fda0ecd86edbb178?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1335b98) will **not change** coverage.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #24421 +/- ##
=======================================
Coverage 73.37% 73.37%
=======================================
Files 718 718
Lines 97101 97101
=======================================
Hits 71252 71252
Misses 24505 24505
Partials 1344 1344
```
| Flag | Coverage Δ | |
|---|---|---|
| go | `51.55% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lostluck commented on pull request #24421: [#24419] Support composite output types in sql.Transform.
Posted by GitBox <gi...@apache.org>.
lostluck commented on PR #24421:
URL: https://github.com/apache/beam/pull/24421#issuecomment-1331453482
Technically a breaking change, but only for uses we don't support anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #24421: [#24419] Support composite output types in sql.Transform.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #24421:
URL: https://github.com/apache/beam/pull/24421#issuecomment-1331484954
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damccorm for label go.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org