You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/17 20:51:00 UTC
[jira] [Commented] (BEAM-2626) Java SDK harness has split packages,
abuses runners/core namespace
[ https://issues.apache.org/jira/browse/BEAM-2626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16090533#comment-16090533 ]
ASF GitHub Bot commented on BEAM-2626:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/3577
[BEAM-2626] Fix split package in SDK harness
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
The Java SDK harness defined classes both in its own namespace org.apache.beam.fn.harness and the org.apache.beam.runners.core namespace, resulting in a split package across multiple jars.
Generally not a good practice since it breaks encapsulation and not actually useful as a hack since that method of breaking encapsulation isn't always compatible with classloader setups.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam harness-split-package
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3577.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3577
----
commit f1b4700f32c5ea39559145d6f5db3909439f6c80
Author: Kenneth Knowles <kl...@google.com>
Date: 2017-07-17T20:46:46Z
Fix split package in SDK harness
The Java SDK harness defined classes both in its own namespace
org.apache.beam.fn.harness and the org.apache.beam.runners.core namespace,
resulting in a split package across multiple jars.
----
> Java SDK harness has split packages, abuses runners/core namespace
> ------------------------------------------------------------------
>
> Key: BEAM-2626
> URL: https://issues.apache.org/jira/browse/BEAM-2626
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)