You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Geoff Callender (JIRA)" <de...@tapestry.apache.org> on 2008/01/25 23:56:34 UTC

[jira] Created: (TAPESTRY-2090) Empty passivated fields aren't passed to onActivate

Empty passivated fields aren't passed to onActivate
---------------------------------------------------

                 Key: TAPESTRY-2090
                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2090
             Project: Tapestry
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.0.9
            Reporter: Geoff Callender


Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-2090) Empty passivated fields aren't passed to onActivate

Posted by "Geoff Callender (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Geoff Callender updated TAPESTRY-2090:
--------------------------------------

    Attachment: ContextFixer.java

> Empty passivated fields aren't passed to onActivate
> ---------------------------------------------------
>
>                 Key: TAPESTRY-2090
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2090
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.9
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.0 Next Release
>
>         Attachments: ContextFixer.java
>
>
> Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2090) Empty passivated fields aren't passed to onActivate

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566847#action_12566847 ] 

Howard M. Lewis Ship commented on TAPESTRY-2090:
------------------------------------------------

This one opens a nest full of vipers.  The consecutive slashes are both meaningful and not meaningful and that's causing at lot of grief.

I can allow a blank/null context value but the logic inside RequestPathOptimizer gets really complicated and ugly.

I'm going to leave this one alone for now.

> Empty passivated fields aren't passed to onActivate
> ---------------------------------------------------
>
>                 Key: TAPESTRY-2090
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2090
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.9
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>
> Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAP5-32) It is not possible to include a null or blank field as part of an event or page activation context

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-32:
-------------------------------------

    Summary: It is not possible to include a null or blank field as part of an event or page activation context  (was: Empty passivated fields aren't passed to onActivate)

> It is not possible to include a null or blank field as part of an event or page activation context
> --------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-32
>                 URL: https://issues.apache.org/jira/browse/TAP5-32
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.0.15
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.0.16
>
>         Attachments: ContextFixer.java
>
>
> Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2090) Empty passivated fields aren't passed to onActivate

Posted by "Geoff Callender (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566970#action_12566970 ] 

Geoff Callender commented on TAPESTRY-2090:
-------------------------------------------

Would it be overly simplistic to replace a blank with "blank" and null with "null", so passivating { "", null, "42", "true" } would become /blank/null/42/true ?

The 2 tricky strings to passivate are "null" and "blank", which could generate "nullnull" and "blankblank". 

Is this too simplistic?  

Currently I do this a pretty clumsy way in onActivate and onPassivate, eg.

	Object[] onPassivate() {
		return new String[] { ContextFixer.packString(_firstName), ContextFixer.packString(_lastName) };
	}

	void onActivate(String firstName, String lastName) {
		_firstName = ContextFixer.unpackString(firstName);
		_lastName = ContextFixer.unpackString(lastName);
	}

The ContextFixer class also handles Boolean and Date.  It's attached.  It would be very nice to not need it!

> Empty passivated fields aren't passed to onActivate
> ---------------------------------------------------
>
>                 Key: TAPESTRY-2090
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2090
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.9
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.0 Next Release
>
>
> Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2090) Empty passivated fields aren't passed to onActivate

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566851#action_12566851 ] 

Howard M. Lewis Ship commented on TAPESTRY-2090:
------------------------------------------------

Although consecutive slashes in the URL are allowed (valid in terms of the BNF), http://www.ietf.org/rfc/rfc1808.txt doesn't explain (or do a good job of explaining) how they should be interpreted.

> Empty passivated fields aren't passed to onActivate
> ---------------------------------------------------
>
>                 Key: TAPESTRY-2090
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2090
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.9
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>             Fix For: 5.0 Next Release
>
>
> Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Closed: (TAP5-32) Empty passivated fields aren't passed to onActivate

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-32?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship closed TAP5-32.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 5.0.16
         Assignee: Howard M. Lewis Ship

> Empty passivated fields aren't passed to onActivate
> ---------------------------------------------------
>
>                 Key: TAP5-32
>                 URL: https://issues.apache.org/jira/browse/TAP5-32
>             Project: Tapestry 5
>          Issue Type: Bug
>    Affects Versions: 5.0.15
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.0.16
>
>         Attachments: ContextFixer.java
>
>
> Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-2090) Empty passivated fields aren't passed to onActivate

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAPESTRY-2090:
-------------------------------------------

         Priority: Minor  (was: Major)
    Fix Version/s: 5.0 Next Release

If you attempt this in 5.0.10, you'll get a defensive excepton that the value can't be null or blank.

> Empty passivated fields aren't passed to onActivate
> ---------------------------------------------------
>
>                 Key: TAPESTRY-2090
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2090
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.9
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>            Priority: Minor
>             Fix For: 5.0 Next Release
>
>
> Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2090) Empty passivated fields aren't passed to onActivate

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566837#action_12566837 ] 

Howard M. Lewis Ship commented on TAPESTRY-2090:
------------------------------------------------

I believe this is an issue with URLs and servlets ... the consecutive slashes are "reduced" to a single slash.

> Empty passivated fields aren't passed to onActivate
> ---------------------------------------------------
>
>                 Key: TAPESTRY-2090
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2090
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.9
>            Reporter: Geoff Callender
>
> Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Updated: (TAPESTRY-2090) Empty passivated fields aren't passed to onActivate

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAPESTRY-2090:
-------------------------------------------

    Assignee:     (was: Howard M. Lewis Ship)

> Empty passivated fields aren't passed to onActivate
> ---------------------------------------------------
>
>                 Key: TAPESTRY-2090
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2090
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.9
>            Reporter: Geoff Callender
>            Priority: Minor
>             Fix For: 5.1
>
>         Attachments: ContextFixer.java
>
>
> Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2090) Empty passivated fields aren't passed to onActivate

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566849#action_12566849 ] 

Howard M. Lewis Ship commented on TAPESTRY-2090:
------------------------------------------------

URL RFC: http://www.ietf.org/rfc/rfc1738.txt

> Empty passivated fields aren't passed to onActivate
> ---------------------------------------------------
>
>                 Key: TAPESTRY-2090
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2090
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.9
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>
> Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Commented: (TAPESTRY-2090) Empty passivated fields aren't passed to onActivate

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
    [ https://issues.apache.org/jira/browse/TAPESTRY-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12566838#action_12566838 ] 

Howard M. Lewis Ship commented on TAPESTRY-2090:
------------------------------------------------

Nope, I think it is actually Tapestry doing that, because of how it uses a String.split() to break apart the path.  this may be a case where a string tokenizer will get the job done better.

> Empty passivated fields aren't passed to onActivate
> ---------------------------------------------------
>
>                 Key: TAPESTRY-2090
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2090
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.9
>            Reporter: Geoff Callender
>
> Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org


[jira] Assigned: (TAPESTRY-2090) Empty passivated fields aren't passed to onActivate

Posted by "Howard M. Lewis Ship (JIRA)" <de...@tapestry.apache.org>.
     [ https://issues.apache.org/jira/browse/TAPESTRY-2090?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship reassigned TAPESTRY-2090:
----------------------------------------------

    Assignee: Howard M. Lewis Ship

> Empty passivated fields aren't passed to onActivate
> ---------------------------------------------------
>
>                 Key: TAPESTRY-2090
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-2090
>             Project: Tapestry
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.0.9
>            Reporter: Geoff Callender
>            Assignee: Howard M. Lewis Ship
>
> Passivating { "", "", "42", "true" }, onActivate receives only 2 elements, { "42", "true" }.  The generated URL appears OK - it ends with ///42/true.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org