You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/10/20 08:28:03 UTC
[GitHub] [jena] ericprud opened a new pull request, #1584: deprecate ShexMap to migrate to ShapeMap
ericprud opened a new pull request, #1584:
URL: https://github.com/apache/jena/pull/1584
per http://shex.io/shape-map/#shapemap-structure
(ShExMap is a different concept.)
GitHub issue resolved #
Pull request Description:
The ShEx `ShapeMap` concept was expressed in a `ShexMap` class. This PR migrates to `ShapeMap`
1. `ShapeMap` extends `ShexMap`.
2. `ShexMap` continues to hold members and member accessors.
3. `ShexMap`'s `.create()` and `Builder` functions return `ShapeMap` and `ShapeMap.Builder`.
4. deprecate `ShexMap`.
In order to verify that tests pass using either ShexMap or ShapeMap, PRs in this test use ShexMap. The next PR migrates tests to ShapeMap.
Are there any docs to fix or will javadoc comments suffice?
This PR obviates #1580
----
- [x] Tests are included.
- [ ] Documentation change and updates are provided for the [Apache Jena website](https://github.com/apache/jena-site/)
- [x] Commits have been squashed to remove intermediate development commit messages.
- [ ] Key commit messages start with the issue number (GH-xxxx or JENA-xxxx)
By submitting this pull request, I acknowledge that I am making a contribution to the Apache Software Foundation under the terms and conditions of the [Contributor's Agreement](https://www.apache.org/licenses/contributor-agreements.html).
----
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] ericprud commented on pull request #1584: deprecate ShexMap to migrate to ShapeMap
Posted by GitBox <gi...@apache.org>.
ericprud commented on PR #1584:
URL: https://github.com/apache/jena/pull/1584#issuecomment-1293340800
replaced by #1589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #1584: deprecate ShexMap to migrate to ShapeMap
Posted by GitBox <gi...@apache.org>.
afs commented on PR #1584:
URL: https://github.com/apache/jena/pull/1584#issuecomment-1289049722
Also included in #1586.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] ericprud closed pull request #1584: deprecate ShexMap to migrate to ShapeMap
Posted by GitBox <gi...@apache.org>.
ericprud closed pull request #1584: deprecate ShexMap to migrate to ShapeMap
URL: https://github.com/apache/jena/pull/1584
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org