You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2016/12/17 22:50:40 UTC
Review Request 54837: Added a CHECK when adding a framework in the
allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54837/
-----------------------------------------------------------
Review request for mesos, Jay Guo and Guangya Liu.
Repository: mesos
Description
-------
Added a CHECK when adding a framework in the allocator.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp a8cbc8db3d1319718765783827f8be1981b56f04
Diff: https://reviews.apache.org/r/54837/diff/
Testing
-------
make check
Thanks,
Benjamin Mahler
Re: Review Request 54837: Added a CHECK when adding a framework in the
allocator.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54837/#review159566
-----------------------------------------------------------
Patch looks great!
Reviews applied: [54837]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 17, 2016, 10:50 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54837/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2016, 10:50 p.m.)
>
>
> Review request for mesos, Jay Guo and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a CHECK when adding a framework in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp a8cbc8db3d1319718765783827f8be1981b56f04
>
> Diff: https://reviews.apache.org/r/54837/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>
Re: Review Request 54837: Added a CHECK when adding a framework in the
allocator.
Posted by Guangya Liu <gy...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54837/#review159565
-----------------------------------------------------------
Ship it!
Ship It!
- Guangya Liu
On \u5341\u4e8c\u6708 17, 2016, 10:50 p.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54837/
> -----------------------------------------------------------
>
> (Updated \u5341\u4e8c\u6708 17, 2016, 10:50 p.m.)
>
>
> Review request for mesos, Jay Guo and Guangya Liu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added a CHECK when adding a framework in the allocator.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp a8cbc8db3d1319718765783827f8be1981b56f04
>
> Diff: https://reviews.apache.org/r/54837/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Mahler
>
>