You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2022/05/12 17:57:52 UTC

[GitHub] [systemds] daphne-eu commented on pull request #1608: [SYSTEMDS-3371] Federated monitoring backend communication with worker nodes

daphne-eu commented on PR #1608:
URL: https://github.com/apache/systemds/pull/1608#issuecomment-1125274817

   Thanks for the patch @MKehayov. As just discussed offline, this looks already good - please double check the fasterxml dependency, tabs vs spaces, exception handling, check of existing schema, use of prepared statements, and a more compact style of assertion checking in the tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@systemds.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org