You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/24 14:27:56 UTC
[GitHub] [dubbo-go] codecov-commenter commented on pull request #539: Fix: defer in loop will cause resource leak
codecov-commenter commented on pull request #539:
URL: https://github.com/apache/dubbo-go/pull/539#issuecomment-633239244
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=h1) Report
> Merging [#539](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/84b38fe643b5b8e99127a7f2f4d6ee2e34cf57e3&el=desc) will **decrease** coverage by `0.22%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #539 +/- ##
===========================================
- Coverage 66.55% 66.33% -0.23%
===========================================
Files 184 184
Lines 9729 9706 -23
===========================================
- Hits 6475 6438 -37
- Misses 2613 2625 +12
- Partials 641 643 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config/service\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnL3NlcnZpY2VfY29uZmlnLmdv) | `71.09% <100.00%> (ø)` | |
| [protocol/dubbo/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vcG9vbC5nbw==) | `76.81% <0.00%> (-4.47%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `57.00% <0.00%> (-1.87%)` | :arrow_down: |
| [common/url.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29tbW9uL3VybC5nbw==) | `65.83% <0.00%> (-1.86%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `78.30% <0.00%> (-0.95%)` | :arrow_down: |
| [cluster/loadbalance/consistent\_hash.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y2x1c3Rlci9sb2FkYmFsYW5jZS9jb25zaXN0ZW50X2hhc2guZ28=) | `90.32% <0.00%> (-0.86%)` | :arrow_down: |
| [config\_center/configurator/override.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9jb25maWd1cmF0b3Ivb3ZlcnJpZGUuZ28=) | `75.00% <0.00%> (-0.41%)` | :arrow_down: |
| [registry/protocol/protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVnaXN0cnkvcHJvdG9jb2wvcHJvdG9jb2wuZ28=) | `80.78% <0.00%> (-0.33%)` | :arrow_down: |
| [registry/consul/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL2xpc3RlbmVyLmdv) | `81.25% <0.00%> (-0.24%)` | :arrow_down: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `56.25% <0.00%> (ø)` | |
| ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/539/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=footer). Last update [84b38fe...159b48e](https://codecov.io/gh/apache/dubbo-go/pull/539?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org