[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2295: Spark: expire catalog cache to avoid hive connection overflow

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #2295:
URL: https://github.com/apache/iceberg/pull/2295#discussion_r594813809



##########
File path: spark2/src/main/java/org/apache/iceberg/spark/source/CustomCatalogs.java
##########
@@ -40,6 +43,12 @@
 
 public final class CustomCatalogs {
   private static final Cache<Pair<SparkSession, String>, Catalog> CATALOG_CACHE = Caffeine.newBuilder()
+      .expireAfterAccess(10, TimeUnit.MINUTES)

Review comment:
       While it is bound to `SparkSession`, it seems introducing a cache timeout can still cause the issues Russell mentioned above.
   
   cc @rymurr @rdblue who developed these places 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org