You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2015/06/03 16:56:53 UTC
Review Request 35005: Alerts JSON Properties Should Allow For A
Mixture of Parameters and Constants
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35005/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Tom Beerbower.
Bugs: AMBARI-11656
https://issues.apache.org/jira/browse/AMBARI-11656
Repository: ambari
Description
-------
For now we don't have ability to add some string if value has {{param}}:
{code}
"http": "{{oozie-site/oozie.base.url}}/oozie/?user.name=oozie"
"http": "{{oozie-site/oozie.base.url}}/oozie/?user.name={{oozie-site/user}}"
{code}
We should be able to replace _n_ parameters mixed with string constants.
Diffs
-----
ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 08fb8a9
ambari-agent/src/test/python/ambari_agent/TestAlerts.py 02efc6f
Diff: https://reviews.apache.org/r/35005/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15.578 s
[INFO] Finished at: 2015-06-03T10:51:37-04:00
[INFO] Final Memory: 16M/310M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 35005: Alerts JSON Properties Should Allow For A
Mixture of Parameters and Constants
Posted by Tom Beerbower <tb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35005/#review86417
-----------------------------------------------------------
Ship it!
Ship It!
- Tom Beerbower
On June 3, 2015, 2:56 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35005/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 2:56 p.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-11656
> https://issues.apache.org/jira/browse/AMBARI-11656
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For now we don't have ability to add some string if value has {{param}}:
> {code}
> "http": "{{oozie-site/oozie.base.url}}/oozie/?user.name=oozie"
> "http": "{{oozie-site/oozie.base.url}}/oozie/?user.name={{oozie-site/user}}"
> {code}
>
> We should be able to replace _n_ parameters mixed with string constants.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 08fb8a9
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 02efc6f
>
> Diff: https://reviews.apache.org/r/35005/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15.578 s
> [INFO] Finished at: 2015-06-03T10:51:37-04:00
> [INFO] Final Memory: 16M/310M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 35005: Alerts JSON Properties Should Allow For A
Mixture of Parameters and Constants
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35005/#review86416
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On June 3, 2015, 10:56 a.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35005/
> -----------------------------------------------------------
>
> (Updated June 3, 2015, 10:56 a.m.)
>
>
> Review request for Ambari, Nate Cole and Tom Beerbower.
>
>
> Bugs: AMBARI-11656
> https://issues.apache.org/jira/browse/AMBARI-11656
>
>
> Repository: ambari
>
>
> Description
> -------
>
> For now we don't have ability to add some string if value has {{param}}:
> {code}
> "http": "{{oozie-site/oozie.base.url}}/oozie/?user.name=oozie"
> "http": "{{oozie-site/oozie.base.url}}/oozie/?user.name={{oozie-site/user}}"
> {code}
>
> We should be able to replace _n_ parameters mixed with string constants.
>
>
> Diffs
> -----
>
> ambari-agent/src/main/python/ambari_agent/alerts/base_alert.py 08fb8a9
> ambari-agent/src/test/python/ambari_agent/TestAlerts.py 02efc6f
>
> Diff: https://reviews.apache.org/r/35005/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 15.578 s
> [INFO] Finished at: 2015-06-03T10:51:37-04:00
> [INFO] Final Memory: 16M/310M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>