You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jobs@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/02 23:38:07 UTC

[GitHub] [airflow]: Workflow run "Build images for Add pre-commits preventing accidental API changes in common.sql https://github.com/apache/airflow/pull/27962 " is working again!

The GitHub Actions job "Build images for Add pre-commits preventing accidental API changes in common.sql https://github.com/apache/airflow/pull/27962
" on airflow.git has succeeded.
Run started by GitHub user potiuk (triggered by potiuk).

Head commit for run:
8dad054e93dac05248dc2728d73d7075c7e39b85 / Jarek Potiuk <ja...@potiuk.com>
Add pre-commits preventing accidental API changes in common.sql

We had recently some mishaps when it comes to changes to the
common.sql provider that accidentally changed API of the common.sql
providers and they passed both tests and reviews.

Common.sql is pretty special provider because it used by other
providers and we have to make sure the API it epxoses is backwards
compatible, otherwise upgrading common.sql provider might break
those providers.

This had already happened:

* The #26761 refactored common.sql provided and removed some
  methods that were actually used by Google Provider

* This caused a problem described in #27838 and forced us ot
  yank common.sql 1.3.0 and release 1.3.1 with the methods
  added back in #27843

This change introduces tools and process to flag common.sql API
changes that are likely backwards compatible.

They will require a deliberate action from the contributor who
introduces a breaking API to common.sql, it will also help to
flag to reviewer when such a change is made.

The idea is based on how Android OS handles flagging API changes
for their public APIs paired with the tooling that MyPy provides
with generating stubs and verifying usage of packages in the
stubs.

Report URL: https://github.com/apache/airflow/actions/runs/3605650750

With regards,
GitHub Actions via GitBox


---------------------------------------------------------------------
To unsubscribe, e-mail: jobs-unsubscribe@airflow.apache.org
For additional commands, e-mail: jobs-help@airflow.apache.org