You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Chris Male (Created) (JIRA)" <ji...@apache.org> on 2012/04/17 07:31:35 UTC
[jira] [Created] (SOLR-3363) Replace RuntimeExceptions in Analysis
Factories
Replace RuntimeExceptions in Analysis Factories
-----------------------------------------------
Key: SOLR-3363
URL: https://issues.apache.org/jira/browse/SOLR-3363
Project: Solr
Issue Type: Improvement
Components: Schema and Analysis
Reporter: Chris Male
Currently there is no consistent use of Exceptions in Analysis factories. Some throw RuntimeExceptions, some throw SolrExceptions, some include information about an Exception they are wrapping, others just wrap, throw and move on.
I think a better way would be to have an InitializationException that the Factories can throw in {{init()}} or {{inform(ResourceLoader)}}. We can then tailor the Exception to meet the needs of the Factories, and it gives us a bit of future proofing if/when we improve the property validation done in the factories.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Resolved] (SOLR-3363) Replace RuntimeExceptions in Analysis
Factories
Posted by "Chris Male (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male resolved SOLR-3363.
------------------------------
Resolution: Fixed
Fix Version/s: 4.0
Assignee: Chris Male
Resolved in trunk.
> Replace RuntimeExceptions in Analysis Factories
> -----------------------------------------------
>
> Key: SOLR-3363
> URL: https://issues.apache.org/jira/browse/SOLR-3363
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Reporter: Chris Male
> Assignee: Chris Male
> Fix For: 4.0
>
> Attachments: SOLR-3363.patch
>
>
> Currently there is no consistent use of Exceptions in Analysis factories. Some throw RuntimeExceptions, some throw SolrExceptions, some include information about an Exception they are wrapping, others just wrap, throw and move on.
> I think a better way would be to have an InitializationException that the Factories can throw in {{init()}} or {{inform(ResourceLoader)}}. We can then tailor the Exception to meet the needs of the Factories, and it gives us a bit of future proofing if/when we improve the property validation done in the factories.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org
[jira] [Updated] (SOLR-3363) Replace RuntimeExceptions in Analysis
Factories
Posted by "Chris Male (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SOLR-3363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Male updated SOLR-3363:
-----------------------------
Attachment: SOLR-3363.patch
Patch.
> Replace RuntimeExceptions in Analysis Factories
> -----------------------------------------------
>
> Key: SOLR-3363
> URL: https://issues.apache.org/jira/browse/SOLR-3363
> Project: Solr
> Issue Type: Improvement
> Components: Schema and Analysis
> Reporter: Chris Male
> Attachments: SOLR-3363.patch
>
>
> Currently there is no consistent use of Exceptions in Analysis factories. Some throw RuntimeExceptions, some throw SolrExceptions, some include information about an Exception they are wrapping, others just wrap, throw and move on.
> I think a better way would be to have an InitializationException that the Factories can throw in {{init()}} or {{inform(ResourceLoader)}}. We can then tailor the Exception to meet the needs of the Factories, and it gives us a bit of future proofing if/when we improve the property validation done in the factories.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org