You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Yu Kobayashi (JIRA)" <ji...@apache.org> on 2008/04/13 08:45:05 UTC

[jira] Created: (EMAIL-76) Some setters of class Email does not return "this".

Some setters of class Email does not return "this".
---------------------------------------------------

                 Key: EMAIL-76
                 URL: https://issues.apache.org/jira/browse/EMAIL-76
             Project: Commons Email
          Issue Type: Bug
            Reporter: Yu Kobayashi
            Priority: Minor


Some setters of class Email return "this", and some doesn't.
For the consistency, all the setters should return "this".


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (EMAIL-76) Some setters of class Email does not return "this".

Posted by "Siegfried Goeschl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/EMAIL-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Siegfried Goeschl resolved EMAIL-76.
------------------------------------

    Resolution: Fixed

> Some setters of class Email does not return "this".
> ---------------------------------------------------
>
>                 Key: EMAIL-76
>                 URL: https://issues.apache.org/jira/browse/EMAIL-76
>             Project: Commons Email
>          Issue Type: Bug
>            Reporter: Yu Kobayashi
>            Assignee: Siegfried Goeschl
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: EmailSetter.patch, MultiPartEmailSetter.patch
>
>
> Some setters of class Email return "this", and some doesn't.
> For the consistency, all the setters should return "this".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (EMAIL-76) Some setters of class Email does not return "this".

Posted by "Siegfried Goeschl (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/EMAIL-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Siegfried Goeschl updated EMAIL-76:
-----------------------------------

    Fix Version/s: 1.3

> Some setters of class Email does not return "this".
> ---------------------------------------------------
>
>                 Key: EMAIL-76
>                 URL: https://issues.apache.org/jira/browse/EMAIL-76
>             Project: Commons Email
>          Issue Type: Bug
>            Reporter: Yu Kobayashi
>            Assignee: Siegfried Goeschl
>            Priority: Minor
>             Fix For: 1.3
>
>         Attachments: EmailSetter.patch, MultiPartEmailSetter.patch
>
>
> Some setters of class Email return "this", and some doesn't.
> For the consistency, all the setters should return "this".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (EMAIL-76) Some setters of class Email does not return "this".

Posted by "Yu Kobayashi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/EMAIL-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yu Kobayashi updated EMAIL-76:
------------------------------

    Attachment: EmailSetter.patch

I created a patch for this problem.


> Some setters of class Email does not return "this".
> ---------------------------------------------------
>
>                 Key: EMAIL-76
>                 URL: https://issues.apache.org/jira/browse/EMAIL-76
>             Project: Commons Email
>          Issue Type: Bug
>            Reporter: Yu Kobayashi
>            Priority: Minor
>         Attachments: EmailSetter.patch
>
>
> Some setters of class Email return "this", and some doesn't.
> For the consistency, all the setters should return "this".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (EMAIL-76) Some setters of class Email does not return "this".

Posted by "Yu Kobayashi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/EMAIL-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yu Kobayashi updated EMAIL-76:
------------------------------

    Attachment: MultiPartEmailSetter.patch

I also created similar patch for the class MultiPartEmail.

Original MultiPartEmail.addPart() downcasts the return value from MultiPartEmail to Email. This is not necessary. I change it to return MultiPartEmail.


> Some setters of class Email does not return "this".
> ---------------------------------------------------
>
>                 Key: EMAIL-76
>                 URL: https://issues.apache.org/jira/browse/EMAIL-76
>             Project: Commons Email
>          Issue Type: Bug
>            Reporter: Yu Kobayashi
>            Priority: Minor
>         Attachments: EmailSetter.patch, MultiPartEmailSetter.patch
>
>
> Some setters of class Email return "this", and some doesn't.
> For the consistency, all the setters should return "this".

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.