You are viewing a plain text version of this content. The canonical link for it is here.
Posted to adffaces-issues@incubator.apache.org by "Frank Felix Debatin (JIRA)" <ji...@apache.org> on 2006/04/19 20:46:39 UTC
[jira] Created: (ADFFACES-1) tableSelectMany may break with
non-string row keys
tableSelectMany may break with non-string row keys
--------------------------------------------------
Key: ADFFACES-1
URL: http://issues.apache.org/jira/browse/ADFFACES-1
Project: MyFaces ADF-Faces
Type: Bug
Environment: all
Reporter: Frank Felix Debatin
from RowKeySet.java: the cast to String is unnecessary and wrong. (This would break if you clicked "Select All", then deselected a row, and had a non-string row key).
private Object _next()
{
while(rowKeyIterator.hasNext())
{
String rowKey = (String) rowKeyIterator.next(); // !?
if (!set.contains(rowKey))
return rowKey;
}
return null;
}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (ADFFACES-1) tableSelectMany may break with
non-string row keys
Posted by "Matthias Weßendorf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-1?page=all ]
Matthias Weßendorf reassigned ADFFACES-1:
-----------------------------------------
Assign To: Adam Winer (was: Matthias Weßendorf)
test
> tableSelectMany may break with non-string row keys
> --------------------------------------------------
>
> Key: ADFFACES-1
> URL: http://issues.apache.org/jira/browse/ADFFACES-1
> Project: MyFaces ADF-Faces
> Type: Bug
> Environment: all
> Reporter: Frank Felix Debatin
> Assignee: Adam Winer
>
> from RowKeySet.java: the cast to String is unnecessary and wrong. (This would break if you clicked "Select All", then deselected a row, and had a non-string row key).
> private Object _next()
> {
> while(rowKeyIterator.hasNext())
> {
> String rowKey = (String) rowKeyIterator.next(); // !?
> if (!set.contains(rowKey))
> return rowKey;
> }
> return null;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-1) tableSelectMany may break with
non-string row keys
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-1?page=comments#action_12375392 ]
Matthias Weßendorf commented on ADFFACES-1:
-------------------------------------------
<snip>
String rowKey = (String) rowKeyIterator.next();
</snip>
is still in the drop, which has been made public during first week of Jan.
> tableSelectMany may break with non-string row keys
> --------------------------------------------------
>
> Key: ADFFACES-1
> URL: http://issues.apache.org/jira/browse/ADFFACES-1
> Project: MyFaces ADF-Faces
> Type: Bug
> Environment: all
> Reporter: Frank Felix Debatin
> Assignee: Adam Winer
>
> from RowKeySet.java: the cast to String is unnecessary and wrong. (This would break if you clicked "Select All", then deselected a row, and had a non-string row key).
> private Object _next()
> {
> while(rowKeyIterator.hasNext())
> {
> String rowKey = (String) rowKeyIterator.next(); // !?
> if (!set.contains(rowKey))
> return rowKey;
> }
> return null;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (ADFFACES-1) tableSelectMany may break with
non-string row keys
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-1?page=all ]
Matthias Weßendorf reassigned ADFFACES-1:
-----------------------------------------
Assign To: Matthias Weßendorf
> tableSelectMany may break with non-string row keys
> --------------------------------------------------
>
> Key: ADFFACES-1
> URL: http://issues.apache.org/jira/browse/ADFFACES-1
> Project: MyFaces ADF-Faces
> Type: Bug
> Environment: all
> Reporter: Frank Felix Debatin
> Assignee: Matthias Weßendorf
>
> from RowKeySet.java: the cast to String is unnecessary and wrong. (This would break if you clicked "Select All", then deselected a row, and had a non-string row key).
> private Object _next()
> {
> while(rowKeyIterator.hasNext())
> {
> String rowKey = (String) rowKeyIterator.next(); // !?
> if (!set.contains(rowKey))
> return rowKey;
> }
> return null;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Closed: (ADFFACES-1) tableSelectMany may break with
non-string row keys
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-1?page=all ]
Adam Winer closed ADFFACES-1:
-----------------------------
Resolution: Fixed
Fixed in SVN drop.
> tableSelectMany may break with non-string row keys
> --------------------------------------------------
>
> Key: ADFFACES-1
> URL: http://issues.apache.org/jira/browse/ADFFACES-1
> Project: MyFaces ADF-Faces
> Type: Bug
> Environment: all
> Reporter: Frank Felix Debatin
> Assignee: Adam Winer
>
> from RowKeySet.java: the cast to String is unnecessary and wrong. (This would break if you clicked "Select All", then deselected a row, and had a non-string row key).
> private Object _next()
> {
> while(rowKeyIterator.hasNext())
> {
> String rowKey = (String) rowKeyIterator.next(); // !?
> if (!set.contains(rowKey))
> return rowKey;
> }
> return null;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-1) tableSelectMany may break with
non-string row keys
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-1?page=comments#action_12375389 ]
Adam Winer commented on ADFFACES-1:
-----------------------------------
This'll be fixed in the first code drop. Thanks for the report.
> tableSelectMany may break with non-string row keys
> --------------------------------------------------
>
> Key: ADFFACES-1
> URL: http://issues.apache.org/jira/browse/ADFFACES-1
> Project: MyFaces ADF-Faces
> Type: Bug
> Environment: all
> Reporter: Frank Felix Debatin
> Assignee: Adam Winer
>
> from RowKeySet.java: the cast to String is unnecessary and wrong. (This would break if you clicked "Select All", then deselected a row, and had a non-string row key).
> private Object _next()
> {
> while(rowKeyIterator.hasNext())
> {
> String rowKey = (String) rowKeyIterator.next(); // !?
> if (!set.contains(rowKey))
> return rowKey;
> }
> return null;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Updated: (ADFFACES-1) tableSelectMany may break with
non-string row keys
Posted by "Matthias Weßendorf (JIRA)" <ad...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/ADFFACES-1?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthias Weßendorf updated ADFFACES-1:
--------------------------------------
Fix Version/s: 1.0.0-incubating-core
Affects Version/s: 1.0.0-incubating-core
> tableSelectMany may break with non-string row keys
> --------------------------------------------------
>
> Key: ADFFACES-1
> URL: https://issues.apache.org/jira/browse/ADFFACES-1
> Project: MyFaces ADF-Faces
> Issue Type: Bug
> Affects Versions: 1.0.0-incubating-core
> Environment: all
> Reporter: Frank Felix Debatin
> Assigned To: Adam Winer
> Fix For: 1.0.0-incubating-core
>
>
> from RowKeySet.java: the cast to String is unnecessary and wrong. (This would break if you clicked "Select All", then deselected a row, and had a non-string row key).
> private Object _next()
> {
> while(rowKeyIterator.hasNext())
> {
> String rowKey = (String) rowKeyIterator.next(); // !?
> if (!set.contains(rowKey))
> return rowKey;
> }
> return null;
> }
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (ADFFACES-1) tableSelectMany may break with
non-string row keys
Posted by "Matthias Weßendorf (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-1?page=all ]
Matthias Weßendorf reassigned ADFFACES-1:
-----------------------------------------
Assign To: Matthias Weßendorf
> tableSelectMany may break with non-string row keys
> --------------------------------------------------
>
> Key: ADFFACES-1
> URL: http://issues.apache.org/jira/browse/ADFFACES-1
> Project: MyFaces ADF-Faces
> Type: Bug
> Environment: all
> Reporter: Frank Felix Debatin
> Assignee: Matthias Weßendorf
>
> from RowKeySet.java: the cast to String is unnecessary and wrong. (This would break if you clicked "Select All", then deselected a row, and had a non-string row key).
> private Object _next()
> {
> while(rowKeyIterator.hasNext())
> {
> String rowKey = (String) rowKeyIterator.next(); // !?
> if (!set.contains(rowKey))
> return rowKey;
> }
> return null;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Assigned: (ADFFACES-1) tableSelectMany may break with
non-string row keys
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-1?page=all ]
Adam Winer reassigned ADFFACES-1:
---------------------------------
Assign To: Adam Winer
> tableSelectMany may break with non-string row keys
> --------------------------------------------------
>
> Key: ADFFACES-1
> URL: http://issues.apache.org/jira/browse/ADFFACES-1
> Project: MyFaces ADF-Faces
> Type: Bug
> Environment: all
> Reporter: Frank Felix Debatin
> Assignee: Adam Winer
>
> from RowKeySet.java: the cast to String is unnecessary and wrong. (This would break if you clicked "Select All", then deselected a row, and had a non-string row key).
> private Object _next()
> {
> while(rowKeyIterator.hasNext())
> {
> String rowKey = (String) rowKeyIterator.next(); // !?
> if (!set.contains(rowKey))
> return rowKey;
> }
> return null;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
[jira] Commented: (ADFFACES-1) tableSelectMany may break with
non-string row keys
Posted by "Adam Winer (JIRA)" <ad...@incubator.apache.org>.
[ http://issues.apache.org/jira/browse/ADFFACES-1?page=comments#action_12375395 ]
Adam Winer commented on ADFFACES-1:
-----------------------------------
I meant the first drop in into the subversion repository...
> tableSelectMany may break with non-string row keys
> --------------------------------------------------
>
> Key: ADFFACES-1
> URL: http://issues.apache.org/jira/browse/ADFFACES-1
> Project: MyFaces ADF-Faces
> Type: Bug
> Environment: all
> Reporter: Frank Felix Debatin
> Assignee: Adam Winer
>
> from RowKeySet.java: the cast to String is unnecessary and wrong. (This would break if you clicked "Select All", then deselected a row, and had a non-string row key).
> private Object _next()
> {
> while(rowKeyIterator.hasNext())
> {
> String rowKey = (String) rowKeyIterator.next(); // !?
> if (!set.contains(rowKey))
> return rowKey;
> }
> return null;
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira