[GitHub] matthiasblaesing commented on issue #437: [NETBEANS-404] Adjust Javadoc font size to editor's zoom level, and avoid all-monospace font

[GitBox <gi...@apache.org>]

matthiasblaesing commented on issue #437: [NETBEANS-404] Adjust Javadoc font size to editor's zoom level, and avoid all-monospace font
URL: https://github.com/apache/incubator-netbeans/pull/437#issuecomment-378016418
 
 
   I'm a bit mixed. I had a quick view through the codebase. The default style of the HTMLEditorKit is changed/potentially changed at a lot of places:
   
   - autoupdate.ui/src/org/netbeans/modules/autoupdate/ui/wizards/PanelBodyContainer.java
   - autoupdate.ui/src/org/netbeans/modules/autoupdate/ui/DetailsPanel.java                                                    
   - code.analysis/src/org/netbeans/modules/analysis/ui/AnalysisResultTopComponent.java
   - editor.completion/src/org/netbeans/modules/editor/completion/HTMLDocView.java                                                        
   - java.j2seplatform/src/org/netbeans/modules/java/j2seplatform/platformdefinition/BrokenPlatformCustomizer.java
   - java.navigation/src/org/netbeans/modules/java/navigation/HTMLDocView.java                                                       
   - openide.dialogs/src/org/openide/WizardDescriptor.java
   - openide.explorer/src/org/openide/explorer/propertysheet/DescriptionComponent.java
   - openide.loaders/src/org/openide/loaders/TemplateWizard1.java
   - projectui/src/org/netbeans/modules/project/ui/TemplatesPanelGUI.java
   
   all these try to modify the base stylesheet of the HTMLEditorKit, which used for all HTMLEditorKits. Othere places modify the stylesheet of a single document and not for the whole kit:
   
   - subversion/src/org/netbeans/modules/subversion/util/NotifyHtmlPanel.java                                                  
   - subversion/src/org/netbeans/modules/subversion/options/SvnOptionsPanel.java
   - subversion/src/org/netbeans/modules/subversion/client/MissingClientPanel.java
   - openide.awt/src/org/openide/awt/SwingBrowserImpl.java
   
   They either just set base styles of add a filtering layer (SwingBrowserImpl).
   
   My take on this: If we want to change the base styles of the HTMLEditorKit, this should be done by one module and I think the `org.netbeans.swing.plaf` (Look & Feel Customization Library) would be the correct place for that. That way we won't get race-conditions for the customizations. If a module needs an individual styling, the stylesheet can be changed on the document level.
   
   @eirikbakke would you be willing to have a closer look at this? I know that I just turned a small problem into a discussion point, but I think bringing it up is the best option.
   
   If a local option is desired, I would check if the stylesheet of the single document that is used, is reset in `HTMLDocView#setContent`. If the stylesheet stays, I think it would be good to change the document stylesheet. If it is reset, it is IMHO worth checking whether resetting the stylesheet each time is an option.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists