You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/03/19 15:34:50 UTC
[GitHub] [hbase] Apache9 commented on a change in pull request #1280:
HBASE-23799 Make our core coprocessors use shaded protobuf
Apache9 commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf
URL: https://github.com/apache/hbase/pull/1280#discussion_r395118645
##########
File path: hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
##########
@@ -82,6 +77,12 @@
import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting;
import org.apache.hbase.thirdparty.com.google.common.base.Throwables;
+import org.apache.hadoop.hbase.shaded.protobuf.ProtobufUtil;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.ClientProtos;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.MultiRowMutationProtos.MultiRowMutationService;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.MultiRowMutationProtos.MutateRowsRequest;
+import org.apache.hadoop.hbase.shaded.protobuf.generated.MultiRowMutationProtos.MutateRowsResponse;
Review comment:
We have multiMutate in this class where we need to make use of MultiRowMutationEndpoint, it is a CPEP so we have to make use of com.google.protobuf instead of the shaded protobuf before this patch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services