You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zhengchenyu (via GitHub)" <gi...@apache.org> on 2023/07/12 09:41:21 UTC
[GitHub] [incubator-uniffle] zhengchenyu opened a new pull request, #1007: [#992] bug(tez): convertTaskAttemptIdToLong should not consider appat…
zhengchenyu opened a new pull request, #1007:
URL: https://github.com/apache/incubator-uniffle/pull/1007
### What changes were proposed in this pull request?
When we convert task attempt id to long, consider real taskAttemptID = taskAttemptID - (appAttemptId - 1) * 1000, the logical only apply to mr. tez should remove this.
If appAttemptId is 2, taskattemptid will be normalized to negative value, it is unexpected.
Fix: #992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] zhengchenyu closed pull request #1007: [#992] fix(tez): convertTaskAttemptIdToLong should not consider appattemptId
Posted by "zhengchenyu (via GitHub)" <gi...@apache.org>.
zhengchenyu closed pull request #1007: [#992] fix(tez): convertTaskAttemptIdToLong should not consider appattemptId
URL: https://github.com/apache/incubator-uniffle/pull/1007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #1007: [#992] fix(tez): convertTaskAttemptIdToLong should not consider appattemptId
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1007:
URL: https://github.com/apache/incubator-uniffle/pull/1007#issuecomment-1637449762
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1007?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1007](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1007?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (3575e8d) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/411b445c060f11f8b2983f587700253c22edd837?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (411b445) will **increase** coverage by `0.21%`.
> The diff coverage is `75.00%`.
```diff
@@ Coverage Diff @@
## master #1007 +/- ##
============================================
+ Coverage 53.67% 53.88% +0.21%
+ Complexity 2523 2384 -139
============================================
Files 381 344 -37
Lines 21648 18193 -3455
Branches 1800 1717 -83
============================================
- Hits 11620 9804 -1816
+ Misses 9322 7790 -1532
+ Partials 706 599 -107
```
| [Impacted Files](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1007?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...c/main/java/org/apache/tez/common/RssTezUtils.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1007?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50LXRlei9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGV6L2NvbW1vbi9Sc3NUZXpVdGlscy5qYXZh) | `63.13% <50.00%> (+0.57%)` | :arrow_up: |
| [...ez/runtime/library/common/sort/impl/RssSorter.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1007?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50LXRlei9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGV6L3J1bnRpbWUvbGlicmFyeS9jb21tb24vc29ydC9pbXBsL1Jzc1NvcnRlci5qYXZh) | `57.95% <100.00%> (-0.48%)` | :arrow_down: |
| [.../runtime/library/common/sort/impl/RssUnSorter.java](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1007?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y2xpZW50LXRlei9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvdGV6L3J1bnRpbWUvbGlicmFyeS9jb21tb24vc29ydC9pbXBsL1Jzc1VuU29ydGVyLmphdmE=) | `63.63% <100.00%> (-0.41%)` | :arrow_down: |
... and [42 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1007/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #1007: [#992] fix(tez): convertTaskAttemptIdToLong should not consider appattemptId
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #1007:
URL: https://github.com/apache/incubator-uniffle/pull/1007
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org