You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/18 23:47:23 UTC

[GitHub] [superset] rusackas commented on a diff in pull request #19692: feat: Update ShortKey for stop query running in SqlLab editor

rusackas commented on code in PR #19692:
URL: https://github.com/apache/superset/pull/19692#discussion_r852488229


##########
superset-frontend/src/SqlLab/components/RunQueryActionButton/index.tsx:
##########
@@ -114,7 +117,9 @@ const RunQueryActionButton = ({
         tooltip={
           (!isDisabled &&
             (shouldShowStopBtn
-              ? t('Stop running (Ctrl + x)')
+              ? userOS === 'MacOS'

Review Comment:
   Willing to take a look at externalizing this, and squeeze it into this PR, @codemaster08240328?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org