You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/03/08 07:49:29 UTC
[GitHub] [spark] maropu commented on a change in pull request #31775: [SPARK-34660][TESTS][3.1] Don't use ParVector with `withExistingConf` which is not thread-safe
maropu commented on a change in pull request #31775:
URL: https://github.com/apache/spark/pull/31775#discussion_r589225142
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -962,7 +962,7 @@ abstract class AnsiCastSuiteBase extends CastSuiteBase {
test("ANSI mode: cast string to timestamp with parse error") {
val activeConf = conf
- new ParVector(ALL_TIMEZONES.toVector).foreach { zid =>
+ ALL_TIMEZONES.foreach { zid =>
Review comment:
nit: It looks like we don't need to wrap `SQLConf.withExistingConf` now.
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -962,7 +962,7 @@ abstract class AnsiCastSuiteBase extends CastSuiteBase {
test("ANSI mode: cast string to timestamp with parse error") {
val activeConf = conf
- new ParVector(ALL_TIMEZONES.toVector).foreach { zid =>
+ ALL_TIMEZONES.foreach { zid =>
def checkCastWithParseError(str: String): Unit = {
Review comment:
nit: It looks like we don't need to wrap `SQLConf.withExistingConf` now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org