You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by "Peter B. West" <pe...@hp.com> on 2006/05/25 15:44:31 UTC

PDFFontDescriptor and PDFFactory

A colleague of mine has just found this:

>>From PDFFontDescriptor
     */
    public PDFFontDescriptor(String basefont, int ascent,
                             int descent, int capHeight, int flags,
                             PDFRectangle fontBBox, int italicAngle,
                             int stemV) {

>>From PDFFactory

            descriptor = new PDFFontDescriptor(desc.getFontName(),
                                         desc.getAscender(),
                                         desc.getDescender(),
                                         desc.getCapHeight(),
                                         desc.getFlags(),
                                         new
PDFRectangle(desc.getFontBBox()),
                                         desc.getStemV(),
                                         desc.getItalicAngle());

Peter


Re: PDFFontDescriptor and PDFFactory

Posted by Chris Bowditch <bo...@hotmail.com>.
Peter B. West wrote:

> A colleague of mine has just found this:
> 
>>>From PDFFontDescriptor
>      */
>     public PDFFontDescriptor(String basefont, int ascent,
>                              int descent, int capHeight, int flags,
>                              PDFRectangle fontBBox, int italicAngle,
>                              int stemV) {
> 
>>>From PDFFactory
> 
>             descriptor = new PDFFontDescriptor(desc.getFontName(),
>                                          desc.getAscender(),
>                                          desc.getDescender(),
>                                          desc.getCapHeight(),
>                                          desc.getFlags(),
>                                          new
> PDFRectangle(desc.getFontBBox()),
>                                          desc.getStemV(),
>                                          desc.getItalicAngle());

Your message is a little cryptic Peter. Are you trying to say there is a 
bug caused by the fact PDFFactory mis-uses the Constructor to 
PDFFontDescriptor? (looks like StemV and italicAngle arguments are 
transposed)

Chris



Re: PDFFontDescriptor and PDFFactory

Posted by Jeremias Maerki <de...@jeremias-maerki.ch>.
Fixed in FOP Trunk. Thanks, Peter. The values are not that important.
That's why we saw it.

On 26.05.2006 14:30:25 Peter B. West wrote:
> On Fri, 2006-05-26 at 12:54 +0100, Chris Bowditch wrote:
> > Peter B. West wrote:
> > 
> > > A colleague of mine has just found this:
> > > 
> > >>From PDFFontDescriptor
> > >      */
> > >     public PDFFontDescriptor(String basefont, int ascent,
> > >                              int descent, int capHeight, int flags,
> > >                              PDFRectangle fontBBox, int italicAngle,
> > >                              int stemV) {
> > > 
> > >>From PDFFactory
> > > 
> > >             descriptor = new PDFFontDescriptor(desc.getFontName(),
> > >                                          desc.getAscender(),
> > >                                          desc.getDescender(),
> > >                                          desc.getCapHeight(),
> > >                                          desc.getFlags(),
> > >                                          new
> > > PDFRectangle(desc.getFontBBox()),
> > >                                          desc.getStemV(),
> > >                                          desc.getItalicAngle());
> > 
> > Your message is a little cryptic Peter. Are you trying to say there is a 
> > bug caused by the fact PDFFactory mis-uses the Constructor to 
> > PDFFontDescriptor? (looks like StemV and italicAngle arguments are 
> > transposed)
> > 
> > Chris
> 
> Chris,
> 
> That's what he pointed out.
> 
> Peter



Jeremias Maerki


Re: PDFFontDescriptor and PDFFactory

Posted by "Peter B. West" <pe...@hp.com>.
On Fri, 2006-05-26 at 12:54 +0100, Chris Bowditch wrote:
> Peter B. West wrote:
> 
> > A colleague of mine has just found this:
> > 
> >>From PDFFontDescriptor
> >      */
> >     public PDFFontDescriptor(String basefont, int ascent,
> >                              int descent, int capHeight, int flags,
> >                              PDFRectangle fontBBox, int italicAngle,
> >                              int stemV) {
> > 
> >>From PDFFactory
> > 
> >             descriptor = new PDFFontDescriptor(desc.getFontName(),
> >                                          desc.getAscender(),
> >                                          desc.getDescender(),
> >                                          desc.getCapHeight(),
> >                                          desc.getFlags(),
> >                                          new
> > PDFRectangle(desc.getFontBBox()),
> >                                          desc.getStemV(),
> >                                          desc.getItalicAngle());
> 
> Your message is a little cryptic Peter. Are you trying to say there is a 
> bug caused by the fact PDFFactory mis-uses the Constructor to 
> PDFFontDescriptor? (looks like StemV and italicAngle arguments are 
> transposed)
> 
> Chris

Chris,

That's what he pointed out.

Peter