You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "Donald Woods (JIRA)" <ji...@apache.org> on 2007/08/16 23:27:30 UTC

[jira] Created: (GERONIMO-3420) Remote deploy of an EAR without an application.xml plan fails

Remote deploy of an EAR without an application.xml plan fails
-------------------------------------------------------------

                 Key: GERONIMO-3420
                 URL: https://issues.apache.org/jira/browse/GERONIMO-3420
             Project: Geronimo
          Issue Type: Bug
      Security Level: public (Regular issues)
          Components: deployment
    Affects Versions: 2.0, 2.0.x, 2.1
         Environment: Two Linux boxes on the same subnet with remoteDeployAddress reconfigured from localhost to the external interface
            Reporter: Donald Woods
            Priority: Critical
             Fix For: 2.0.x, 2.1


Remote deploy of an EAR that doesn't have a application.xml fails, because the EARConfigBuilder.getEarPlan() is looking for the module/earFile to end with ".ear" to determine if it is an EAR w/o an app plan, but when using the remoteDeployer, the files are created as temp files without an extension, like remote-deploy31452 -

    private ApplicationInfo getEarPlan(File planFile, JarFile earFile, ModuleIDBuilder idBuilder) throws DeploymentException {
        String specDD;
        ApplicationType application = null;
        if (earFile != null) {
            try {
                URL applicationXmlUrl = DeploymentUtil.createJarURL(earFile, "META-INF/application.xml");
                specDD = DeploymentUtil.readAll(applicationXmlUrl);
                //we found something called application.xml in the right place, if we can't parse it it's an error
                XmlObject xmlObject = XmlBeansUtil.parse(specDD);
                application = convertToApplicationSchema(xmlObject).getApplication();
            } catch (XmlException e) {
                throw new DeploymentException("Could not parse application.xml", e);
            } catch (Exception e) {
                //ee5 spec allows optional application.xml, continue with application == null
                if (!earFile.getName().endsWith(".ear")) {
                    return null;
                }
                //TODO return application.xml that we can make metadata complete?
            }
        }



-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3420) Remote deploy of an EAR without an application.xml plan fails

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12521275 ] 

Donald Woods commented on GERONIMO-3420:
----------------------------------------

Also, the remote-deploy configs are missing geronimo-plugin.xml files, so they can't just be redeployed for easy testing....


> Remote deploy of an EAR without an application.xml plan fails
> -------------------------------------------------------------
>
>                 Key: GERONIMO-3420
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3420
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0, 2.0.x, 2.1
>         Environment: Two Linux boxes on the same subnet with remoteDeployAddress reconfigured from localhost to the external interface
>            Reporter: Donald Woods
>            Assignee: Donald Woods
>            Priority: Critical
>             Fix For: 2.0.x, 2.1
>
>
> Remote deploy of an EAR that doesn't have a application.xml fails, because the EARConfigBuilder.getEarPlan() is looking for the module/earFile to end with ".ear" to determine if it is an EAR w/o an app plan, but when using the remoteDeployer, the files are created as temp files without an extension, like remote-deploy31452 -
>     private ApplicationInfo getEarPlan(File planFile, JarFile earFile, ModuleIDBuilder idBuilder) throws DeploymentException {
>         String specDD;
>         ApplicationType application = null;
>         if (earFile != null) {
>             try {
>                 URL applicationXmlUrl = DeploymentUtil.createJarURL(earFile, "META-INF/application.xml");
>                 specDD = DeploymentUtil.readAll(applicationXmlUrl);
>                 //we found something called application.xml in the right place, if we can't parse it it's an error
>                 XmlObject xmlObject = XmlBeansUtil.parse(specDD);
>                 application = convertToApplicationSchema(xmlObject).getApplication();
>             } catch (XmlException e) {
>                 throw new DeploymentException("Could not parse application.xml", e);
>             } catch (Exception e) {
>                 //ee5 spec allows optional application.xml, continue with application == null
>                 if (!earFile.getName().endsWith(".ear")) {
>                     return null;
>                 }
>                 //TODO return application.xml that we can make metadata complete?
>             }
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Reopened: (GERONIMO-3420) Remote deploy of an EAR without an application.xml plan fails

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods reopened GERONIMO-3420:
------------------------------------


Remote deployment of WAR files need their original filenames, so the context root will be set correctly for default cases...

> Remote deploy of an EAR without an application.xml plan fails
> -------------------------------------------------------------
>
>                 Key: GERONIMO-3420
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3420
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0, 2.0.x, 2.1
>         Environment: Two Linux boxes on the same subnet with remoteDeployAddress reconfigured from localhost to the external interface
>            Reporter: Donald Woods
>            Assignee: Donald Woods
>            Priority: Critical
>             Fix For: 2.0.x, 2.1
>
>
> Remote deploy of an EAR that doesn't have a application.xml fails, because the EARConfigBuilder.getEarPlan() is looking for the module/earFile to end with ".ear" to determine if it is an EAR w/o an app plan, but when using the remoteDeployer, the files are created as temp files without an extension, like remote-deploy31452 -
>     private ApplicationInfo getEarPlan(File planFile, JarFile earFile, ModuleIDBuilder idBuilder) throws DeploymentException {
>         String specDD;
>         ApplicationType application = null;
>         if (earFile != null) {
>             try {
>                 URL applicationXmlUrl = DeploymentUtil.createJarURL(earFile, "META-INF/application.xml");
>                 specDD = DeploymentUtil.readAll(applicationXmlUrl);
>                 //we found something called application.xml in the right place, if we can't parse it it's an error
>                 XmlObject xmlObject = XmlBeansUtil.parse(specDD);
>                 application = convertToApplicationSchema(xmlObject).getApplication();
>             } catch (XmlException e) {
>                 throw new DeploymentException("Could not parse application.xml", e);
>             } catch (Exception e) {
>                 //ee5 spec allows optional application.xml, continue with application == null
>                 if (!earFile.getName().endsWith(".ear")) {
>                     return null;
>                 }
>                 //TODO return application.xml that we can make metadata complete?
>             }
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GERONIMO-3420) Remote deploy of an EAR without an application.xml plan fails

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods closed GERONIMO-3420.
----------------------------------

    Resolution: Fixed

Committed revision 567215 in branches/2.0 (2.0.2-SNAPSHOT)
Committed revision 567217 in trunk (2.1-SNAPSHOT)

> Remote deploy of an EAR without an application.xml plan fails
> -------------------------------------------------------------
>
>                 Key: GERONIMO-3420
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3420
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0, 2.0.x, 2.1
>         Environment: Two Linux boxes on the same subnet with remoteDeployAddress reconfigured from localhost to the external interface
>            Reporter: Donald Woods
>            Assignee: Donald Woods
>            Priority: Critical
>             Fix For: 2.0.x, 2.1
>
>
> Remote deploy of an EAR that doesn't have a application.xml fails, because the EARConfigBuilder.getEarPlan() is looking for the module/earFile to end with ".ear" to determine if it is an EAR w/o an app plan, but when using the remoteDeployer, the files are created as temp files without an extension, like remote-deploy31452 -
>     private ApplicationInfo getEarPlan(File planFile, JarFile earFile, ModuleIDBuilder idBuilder) throws DeploymentException {
>         String specDD;
>         ApplicationType application = null;
>         if (earFile != null) {
>             try {
>                 URL applicationXmlUrl = DeploymentUtil.createJarURL(earFile, "META-INF/application.xml");
>                 specDD = DeploymentUtil.readAll(applicationXmlUrl);
>                 //we found something called application.xml in the right place, if we can't parse it it's an error
>                 XmlObject xmlObject = XmlBeansUtil.parse(specDD);
>                 application = convertToApplicationSchema(xmlObject).getApplication();
>             } catch (XmlException e) {
>                 throw new DeploymentException("Could not parse application.xml", e);
>             } catch (Exception e) {
>                 //ee5 spec allows optional application.xml, continue with application == null
>                 if (!earFile.getName().endsWith(".ear")) {
>                     return null;
>                 }
>                 //TODO return application.xml that we can make metadata complete?
>             }
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMO-3420) Remote deploy of an EAR without an application.xml plan fails

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods updated GERONIMO-3420:
-----------------------------------

    Fix Version/s:     (was: 2.0.x)
                   2.0.2

Added Fixed For 2.0.2, so we can generate a correct list of fixed JIRAs for 2.0.2.

> Remote deploy of an EAR without an application.xml plan fails
> -------------------------------------------------------------
>
>                 Key: GERONIMO-3420
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3420
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0, 2.0.x, 2.1
>         Environment: Two Linux boxes on the same subnet with remoteDeployAddress reconfigured from localhost to the external interface
>            Reporter: Donald Woods
>            Assignee: Donald Woods
>            Priority: Critical
>             Fix For: 2.0.2, 2.1
>
>
> Remote deploy of an EAR that doesn't have a application.xml fails, because the EARConfigBuilder.getEarPlan() is looking for the module/earFile to end with ".ear" to determine if it is an EAR w/o an app plan, but when using the remoteDeployer, the files are created as temp files without an extension, like remote-deploy31452 -
>     private ApplicationInfo getEarPlan(File planFile, JarFile earFile, ModuleIDBuilder idBuilder) throws DeploymentException {
>         String specDD;
>         ApplicationType application = null;
>         if (earFile != null) {
>             try {
>                 URL applicationXmlUrl = DeploymentUtil.createJarURL(earFile, "META-INF/application.xml");
>                 specDD = DeploymentUtil.readAll(applicationXmlUrl);
>                 //we found something called application.xml in the right place, if we can't parse it it's an error
>                 XmlObject xmlObject = XmlBeansUtil.parse(specDD);
>                 application = convertToApplicationSchema(xmlObject).getApplication();
>             } catch (XmlException e) {
>                 throw new DeploymentException("Could not parse application.xml", e);
>             } catch (Exception e) {
>                 //ee5 spec allows optional application.xml, continue with application == null
>                 if (!earFile.getName().endsWith(".ear")) {
>                     return null;
>                 }
>                 //TODO return application.xml that we can make metadata complete?
>             }
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3420) Remote deploy of an EAR without an application.xml plan fails

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520383 ] 

Donald Woods commented on GERONIMO-3420:
----------------------------------------

TomcatModuleBuilder may be impacted by this lack of file extension, too -

        } catch (XmlException e) {
            // Output the target path in the error to make it clearer to the user which webapp
            // has the problem.  The targetPath is used, as moduleFile may have an unhelpful
            // value such as C:\geronimo-1.1\var\temp\geronimo-deploymentUtil22826.tmpdir
            throw new DeploymentException("Error parsing web.xml for " + targetPath, e);
        } catch (Exception e) {
            if (!moduleFile.getName().endsWith(".war")) {
                //not for us
                return null;
            }
            isJavaee = true;
            //else ignore as jee5 allows optional spec dd for .war's
        }



> Remote deploy of an EAR without an application.xml plan fails
> -------------------------------------------------------------
>
>                 Key: GERONIMO-3420
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3420
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0, 2.0.x, 2.1
>         Environment: Two Linux boxes on the same subnet with remoteDeployAddress reconfigured from localhost to the external interface
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 2.0.x, 2.1
>
>
> Remote deploy of an EAR that doesn't have a application.xml fails, because the EARConfigBuilder.getEarPlan() is looking for the module/earFile to end with ".ear" to determine if it is an EAR w/o an app plan, but when using the remoteDeployer, the files are created as temp files without an extension, like remote-deploy31452 -
>     private ApplicationInfo getEarPlan(File planFile, JarFile earFile, ModuleIDBuilder idBuilder) throws DeploymentException {
>         String specDD;
>         ApplicationType application = null;
>         if (earFile != null) {
>             try {
>                 URL applicationXmlUrl = DeploymentUtil.createJarURL(earFile, "META-INF/application.xml");
>                 specDD = DeploymentUtil.readAll(applicationXmlUrl);
>                 //we found something called application.xml in the right place, if we can't parse it it's an error
>                 XmlObject xmlObject = XmlBeansUtil.parse(specDD);
>                 application = convertToApplicationSchema(xmlObject).getApplication();
>             } catch (XmlException e) {
>                 throw new DeploymentException("Could not parse application.xml", e);
>             } catch (Exception e) {
>                 //ee5 spec allows optional application.xml, continue with application == null
>                 if (!earFile.getName().endsWith(".ear")) {
>                     return null;
>                 }
>                 //TODO return application.xml that we can make metadata complete?
>             }
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (GERONIMO-3420) Remote deploy of an EAR without an application.xml plan fails

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods closed GERONIMO-3420.
----------------------------------

    Resolution: Fixed

Committed revision 567934 in branches/2.0
Committed revision 567944 in trunk

> Remote deploy of an EAR without an application.xml plan fails
> -------------------------------------------------------------
>
>                 Key: GERONIMO-3420
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3420
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0, 2.0.x, 2.1
>         Environment: Two Linux boxes on the same subnet with remoteDeployAddress reconfigured from localhost to the external interface
>            Reporter: Donald Woods
>            Assignee: Donald Woods
>            Priority: Critical
>             Fix For: 2.0.x, 2.1
>
>
> Remote deploy of an EAR that doesn't have a application.xml fails, because the EARConfigBuilder.getEarPlan() is looking for the module/earFile to end with ".ear" to determine if it is an EAR w/o an app plan, but when using the remoteDeployer, the files are created as temp files without an extension, like remote-deploy31452 -
>     private ApplicationInfo getEarPlan(File planFile, JarFile earFile, ModuleIDBuilder idBuilder) throws DeploymentException {
>         String specDD;
>         ApplicationType application = null;
>         if (earFile != null) {
>             try {
>                 URL applicationXmlUrl = DeploymentUtil.createJarURL(earFile, "META-INF/application.xml");
>                 specDD = DeploymentUtil.readAll(applicationXmlUrl);
>                 //we found something called application.xml in the right place, if we can't parse it it's an error
>                 XmlObject xmlObject = XmlBeansUtil.parse(specDD);
>                 application = convertToApplicationSchema(xmlObject).getApplication();
>             } catch (XmlException e) {
>                 throw new DeploymentException("Could not parse application.xml", e);
>             } catch (Exception e) {
>                 //ee5 spec allows optional application.xml, continue with application == null
>                 if (!earFile.getName().endsWith(".ear")) {
>                     return null;
>                 }
>                 //TODO return application.xml that we can make metadata complete?
>             }
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (GERONIMO-3420) Remote deploy of an EAR without an application.xml plan fails

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMO-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Donald Woods reassigned GERONIMO-3420:
--------------------------------------

    Assignee: Donald Woods

> Remote deploy of an EAR without an application.xml plan fails
> -------------------------------------------------------------
>
>                 Key: GERONIMO-3420
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3420
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0, 2.0.x, 2.1
>         Environment: Two Linux boxes on the same subnet with remoteDeployAddress reconfigured from localhost to the external interface
>            Reporter: Donald Woods
>            Assignee: Donald Woods
>            Priority: Critical
>             Fix For: 2.0.x, 2.1
>
>
> Remote deploy of an EAR that doesn't have a application.xml fails, because the EARConfigBuilder.getEarPlan() is looking for the module/earFile to end with ".ear" to determine if it is an EAR w/o an app plan, but when using the remoteDeployer, the files are created as temp files without an extension, like remote-deploy31452 -
>     private ApplicationInfo getEarPlan(File planFile, JarFile earFile, ModuleIDBuilder idBuilder) throws DeploymentException {
>         String specDD;
>         ApplicationType application = null;
>         if (earFile != null) {
>             try {
>                 URL applicationXmlUrl = DeploymentUtil.createJarURL(earFile, "META-INF/application.xml");
>                 specDD = DeploymentUtil.readAll(applicationXmlUrl);
>                 //we found something called application.xml in the right place, if we can't parse it it's an error
>                 XmlObject xmlObject = XmlBeansUtil.parse(specDD);
>                 application = convertToApplicationSchema(xmlObject).getApplication();
>             } catch (XmlException e) {
>                 throw new DeploymentException("Could not parse application.xml", e);
>             } catch (Exception e) {
>                 //ee5 spec allows optional application.xml, continue with application == null
>                 if (!earFile.getName().endsWith(".ear")) {
>                     return null;
>                 }
>                 //TODO return application.xml that we can make metadata complete?
>             }
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3420) Remote deploy of an EAR without an application.xml plan fails

Posted by "David Jencks (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520432 ] 

David Jencks commented on GERONIMO-3420:
----------------------------------------

I saw an offline suggestion to include the name of each file in the protocol the remote deploy servlet/RemoteDeployUtil use.  I think this is a good idea.  I suggest that the protocol also be modified to start with a version byte so the next time we change the protocol we can preserve backward compatibility.

> Remote deploy of an EAR without an application.xml plan fails
> -------------------------------------------------------------
>
>                 Key: GERONIMO-3420
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3420
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0, 2.0.x, 2.1
>         Environment: Two Linux boxes on the same subnet with remoteDeployAddress reconfigured from localhost to the external interface
>            Reporter: Donald Woods
>            Priority: Critical
>             Fix For: 2.0.x, 2.1
>
>
> Remote deploy of an EAR that doesn't have a application.xml fails, because the EARConfigBuilder.getEarPlan() is looking for the module/earFile to end with ".ear" to determine if it is an EAR w/o an app plan, but when using the remoteDeployer, the files are created as temp files without an extension, like remote-deploy31452 -
>     private ApplicationInfo getEarPlan(File planFile, JarFile earFile, ModuleIDBuilder idBuilder) throws DeploymentException {
>         String specDD;
>         ApplicationType application = null;
>         if (earFile != null) {
>             try {
>                 URL applicationXmlUrl = DeploymentUtil.createJarURL(earFile, "META-INF/application.xml");
>                 specDD = DeploymentUtil.readAll(applicationXmlUrl);
>                 //we found something called application.xml in the right place, if we can't parse it it's an error
>                 XmlObject xmlObject = XmlBeansUtil.parse(specDD);
>                 application = convertToApplicationSchema(xmlObject).getApplication();
>             } catch (XmlException e) {
>                 throw new DeploymentException("Could not parse application.xml", e);
>             } catch (Exception e) {
>                 //ee5 spec allows optional application.xml, continue with application == null
>                 if (!earFile.getName().endsWith(".ear")) {
>                     return null;
>                 }
>                 //TODO return application.xml that we can make metadata complete?
>             }
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMO-3420) Remote deploy of an EAR without an application.xml plan fails

Posted by "Donald Woods (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMO-3420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12520624 ] 

Donald Woods commented on GERONIMO-3420:
----------------------------------------

Updating the datastream to include a leading version number as an int and changing the file length to a Long -

 * RemoteDeployer data stream format:
 *   0) an int, the version of this datastream format - REMOTE_DEPLOY_REQUEST_VER
 *   1) an int, the number of files being uploaded
 *   2) for each file:
 *     2.0) a UTF String, the filename of the file being uploaded
 *     2.1) a long, the length of the file in bytes
 *     2.2) byte[], byte count equal to the number above for the file
 *
 * RemoteDeployer response stream format:
 *   It returns a serialized stream containing:
 *   0) an int, the version of this datastream format - REMOTE_DEPLOY_RESPONSE_VER
 *   1) a UTF string, the status (should be "OK")
 *   2) an int, the number of files received
 *   3) for each file:
 *     3.1) a UTF String, the path to the file as saved to the server's filesystem



> Remote deploy of an EAR without an application.xml plan fails
> -------------------------------------------------------------
>
>                 Key: GERONIMO-3420
>                 URL: https://issues.apache.org/jira/browse/GERONIMO-3420
>             Project: Geronimo
>          Issue Type: Bug
>      Security Level: public(Regular issues) 
>          Components: deployment
>    Affects Versions: 2.0, 2.0.x, 2.1
>         Environment: Two Linux boxes on the same subnet with remoteDeployAddress reconfigured from localhost to the external interface
>            Reporter: Donald Woods
>            Assignee: Donald Woods
>            Priority: Critical
>             Fix For: 2.0.x, 2.1
>
>
> Remote deploy of an EAR that doesn't have a application.xml fails, because the EARConfigBuilder.getEarPlan() is looking for the module/earFile to end with ".ear" to determine if it is an EAR w/o an app plan, but when using the remoteDeployer, the files are created as temp files without an extension, like remote-deploy31452 -
>     private ApplicationInfo getEarPlan(File planFile, JarFile earFile, ModuleIDBuilder idBuilder) throws DeploymentException {
>         String specDD;
>         ApplicationType application = null;
>         if (earFile != null) {
>             try {
>                 URL applicationXmlUrl = DeploymentUtil.createJarURL(earFile, "META-INF/application.xml");
>                 specDD = DeploymentUtil.readAll(applicationXmlUrl);
>                 //we found something called application.xml in the right place, if we can't parse it it's an error
>                 XmlObject xmlObject = XmlBeansUtil.parse(specDD);
>                 application = convertToApplicationSchema(xmlObject).getApplication();
>             } catch (XmlException e) {
>                 throw new DeploymentException("Could not parse application.xml", e);
>             } catch (Exception e) {
>                 //ee5 spec allows optional application.xml, continue with application == null
>                 if (!earFile.getName().endsWith(".ear")) {
>                     return null;
>                 }
>                 //TODO return application.xml that we can make metadata complete?
>             }
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.