[GitHub] libcloud pull request #1049: Fixies for docker

[johnnyWalnut <gi...@git.apache.org>]

GitHub user johnnyWalnut opened a pull request:

    https://github.com/apache/libcloud/pull/1049

    Fixies for docker

    ## Fixies for docker
    
    ### Description
    
    Docker remote has change its call for start a container. As we can check here:
    https://docs.docker.com/engine/api/version-history/#v124-api-changes
    The previous implementation doesn't work and throws the following error:
    ```
    /home/johnny/Documents/mylibcloud/libcloudfine/fork_libcloud/libcloud/libcloud/common/base.pyc in __init__(self, response, connection)
        159         if not self.success():
        160             raise exception_from_message(code=self.status,
    --> 161                                          message=self.parse_error())
        162
        163         self.object = self.parse_body()
    
    BaseHTTPError: {"message":"starting container with non-empty request body was deprecated since v1.10 and removed in v1.12"}
    (where v refers to docker version)
    ```
    So i changed the implementation to work like:
    ```POST /containers/(id or name)/start``` without data
    
    Also, i add one more line which checks container status, because
    this changed also, ```status=(created	restarting	running	paused	exited	dead)```
    in API v 1.24 ```https://docs.docker.com/engine/api/v1.24/```
    
    ### Status
    
    - done, ready for review
    
    ### Checklist (tick everything that applies)
    
    - [x] [Code linting](http://libcloud.readthedocs.org/en/latest/development.html#code-style-guide) (required, can be done after the PR checks)
    - [x] [Tests](http://libcloud.readthedocs.org/en/latest/testing.html)
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnnyWalnut/libcloud fixies_for_docker

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/libcloud/pull/1049.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1049
    
----
commit e7ab1dd9e3ee9e54f9daa09af4e0e10c8c676f99
Author: johnnyWalnut <ik...@gmail.com>
Date:   2017-04-28T11:02:03Z

    update request for start_container, it doesn't send data any more

commit d01db287665c11d1ff0367cb9357baad580b579b
Author: johnnyWalnut <ik...@gmail.com>
Date:   2017-04-28T11:06:59Z

    check docker v1.23 API changes

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] libcloud pull request #1049: Fixies for docker

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/libcloud/pull/1049


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---