You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ignite.apache.org by Alexander Polovtcev <al...@gmail.com> on 2022/01/13 10:25:02 UTC
[VOTE] @Nullable/@NotNull annotation usage in Ignite 3
Dear Igniters,
In this thread
<https://lists.apache.org/thread/2l50swqd1dymf2qjgrb4wqrbmwjtj02f> we've
discussed possible approaches to using null-related annotations. As the
result, the following approaches were proposed:
1. Use both @Nullable and @NotNull annotations everywhere;
2. Use only @Nullable;
3. Use only @NotNull;
4. Do not use* @*Nullable nor @NotNull.
I would like to propose a vote: please post the corresponding number of the
option you like. The voting will commence on Thursday, January 20 at 11:00
UTC.
--
With regards,
Aleksandr Polovtcev
Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3
Posted by Alexander Polovtcev <al...@gmail.com>.
Thanks everybody, the voting has finished. Here are the results:
Option 2: 7 votes
Option 4: 2 votes
Other options: 0 votes
Looks like the Option 2 is preferred, I will create a more formal
description of it in Confluence as soon as we have the Ignite 3 code style
page set up.
On Thu, Jan 13, 2022 at 7:00 PM Valentin Kulichenko <
valentin.kulichenko@gmail.com> wrote:
> +1 for option 2
>
> On Thu, Jan 13, 2022 at 6:17 AM Anton Vinogradov <av...@apache.org> wrote:
>
> > +1 to option 4
> >
> > On Thu, Jan 13, 2022 at 5:15 PM Pavel Tupitsyn <pt...@apache.org>
> > wrote:
> >
> > > +1 to option 2
> > >
> > > On Thu, Jan 13, 2022 at 3:52 PM Roman Puchkovskiy <
> > > roman.puchkovskiy@gmail.com> wrote:
> > >
> > > > +1 to option 2
> > > >
> > > > чт, 13 янв. 2022 г. в 15:58, Sergey <ma...@gmail.com>:
> > > > >
> > > > > +1 for option2 (only @Nullable)
> > > > >
> > > > > Best regards,
> > > > > Sergey Kosarev.
> > > > >
> > > > >
> > > > > чт, 13 янв. 2022 г. в 13:25, Alexander Polovtcev <
> > > > alexpolovtcev@gmail.com>:
> > > > >
> > > > > > Dear Igniters,
> > > > > >
> > > > > > In this thread
> > > > > > <
> https://lists.apache.org/thread/2l50swqd1dymf2qjgrb4wqrbmwjtj02f>
> > > > we've
> > > > > > discussed possible approaches to using null-related annotations.
> As
> > > the
> > > > > > result, the following approaches were proposed:
> > > > > >
> > > > > > 1. Use both @Nullable and @NotNull annotations everywhere;
> > > > > > 2. Use only @Nullable;
> > > > > > 3. Use only @NotNull;
> > > > > > 4. Do not use* @*Nullable nor @NotNull.
> > > > > >
> > > > > > I would like to propose a vote: please post the corresponding
> > number
> > > > of the
> > > > > > option you like. The voting will commence on Thursday, January 20
> > at
> > > > 11:00
> > > > > > UTC.
> > > > > >
> > > > > > --
> > > > > > With regards,
> > > > > > Aleksandr Polovtcev
> > > > > >
> > > >
> > >
> >
>
--
With regards,
Aleksandr Polovtcev
Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3
Posted by Valentin Kulichenko <va...@gmail.com>.
+1 for option 2
On Thu, Jan 13, 2022 at 6:17 AM Anton Vinogradov <av...@apache.org> wrote:
> +1 to option 4
>
> On Thu, Jan 13, 2022 at 5:15 PM Pavel Tupitsyn <pt...@apache.org>
> wrote:
>
> > +1 to option 2
> >
> > On Thu, Jan 13, 2022 at 3:52 PM Roman Puchkovskiy <
> > roman.puchkovskiy@gmail.com> wrote:
> >
> > > +1 to option 2
> > >
> > > чт, 13 янв. 2022 г. в 15:58, Sergey <ma...@gmail.com>:
> > > >
> > > > +1 for option2 (only @Nullable)
> > > >
> > > > Best regards,
> > > > Sergey Kosarev.
> > > >
> > > >
> > > > чт, 13 янв. 2022 г. в 13:25, Alexander Polovtcev <
> > > alexpolovtcev@gmail.com>:
> > > >
> > > > > Dear Igniters,
> > > > >
> > > > > In this thread
> > > > > <https://lists.apache.org/thread/2l50swqd1dymf2qjgrb4wqrbmwjtj02f>
> > > we've
> > > > > discussed possible approaches to using null-related annotations. As
> > the
> > > > > result, the following approaches were proposed:
> > > > >
> > > > > 1. Use both @Nullable and @NotNull annotations everywhere;
> > > > > 2. Use only @Nullable;
> > > > > 3. Use only @NotNull;
> > > > > 4. Do not use* @*Nullable nor @NotNull.
> > > > >
> > > > > I would like to propose a vote: please post the corresponding
> number
> > > of the
> > > > > option you like. The voting will commence on Thursday, January 20
> at
> > > 11:00
> > > > > UTC.
> > > > >
> > > > > --
> > > > > With regards,
> > > > > Aleksandr Polovtcev
> > > > >
> > >
> >
>
Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3
Posted by Anton Vinogradov <av...@apache.org>.
+1 to option 4
On Thu, Jan 13, 2022 at 5:15 PM Pavel Tupitsyn <pt...@apache.org> wrote:
> +1 to option 2
>
> On Thu, Jan 13, 2022 at 3:52 PM Roman Puchkovskiy <
> roman.puchkovskiy@gmail.com> wrote:
>
> > +1 to option 2
> >
> > чт, 13 янв. 2022 г. в 15:58, Sergey <ma...@gmail.com>:
> > >
> > > +1 for option2 (only @Nullable)
> > >
> > > Best regards,
> > > Sergey Kosarev.
> > >
> > >
> > > чт, 13 янв. 2022 г. в 13:25, Alexander Polovtcev <
> > alexpolovtcev@gmail.com>:
> > >
> > > > Dear Igniters,
> > > >
> > > > In this thread
> > > > <https://lists.apache.org/thread/2l50swqd1dymf2qjgrb4wqrbmwjtj02f>
> > we've
> > > > discussed possible approaches to using null-related annotations. As
> the
> > > > result, the following approaches were proposed:
> > > >
> > > > 1. Use both @Nullable and @NotNull annotations everywhere;
> > > > 2. Use only @Nullable;
> > > > 3. Use only @NotNull;
> > > > 4. Do not use* @*Nullable nor @NotNull.
> > > >
> > > > I would like to propose a vote: please post the corresponding number
> > of the
> > > > option you like. The voting will commence on Thursday, January 20 at
> > 11:00
> > > > UTC.
> > > >
> > > > --
> > > > With regards,
> > > > Aleksandr Polovtcev
> > > >
> >
>
Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3
Posted by Pavel Tupitsyn <pt...@apache.org>.
+1 to option 2
On Thu, Jan 13, 2022 at 3:52 PM Roman Puchkovskiy <
roman.puchkovskiy@gmail.com> wrote:
> +1 to option 2
>
> чт, 13 янв. 2022 г. в 15:58, Sergey <ma...@gmail.com>:
> >
> > +1 for option2 (only @Nullable)
> >
> > Best regards,
> > Sergey Kosarev.
> >
> >
> > чт, 13 янв. 2022 г. в 13:25, Alexander Polovtcev <
> alexpolovtcev@gmail.com>:
> >
> > > Dear Igniters,
> > >
> > > In this thread
> > > <https://lists.apache.org/thread/2l50swqd1dymf2qjgrb4wqrbmwjtj02f>
> we've
> > > discussed possible approaches to using null-related annotations. As the
> > > result, the following approaches were proposed:
> > >
> > > 1. Use both @Nullable and @NotNull annotations everywhere;
> > > 2. Use only @Nullable;
> > > 3. Use only @NotNull;
> > > 4. Do not use* @*Nullable nor @NotNull.
> > >
> > > I would like to propose a vote: please post the corresponding number
> of the
> > > option you like. The voting will commence on Thursday, January 20 at
> 11:00
> > > UTC.
> > >
> > > --
> > > With regards,
> > > Aleksandr Polovtcev
> > >
>
Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3
Posted by Roman Puchkovskiy <ro...@gmail.com>.
+1 to option 2
чт, 13 янв. 2022 г. в 15:58, Sergey <ma...@gmail.com>:
>
> +1 for option2 (only @Nullable)
>
> Best regards,
> Sergey Kosarev.
>
>
> чт, 13 янв. 2022 г. в 13:25, Alexander Polovtcev <al...@gmail.com>:
>
> > Dear Igniters,
> >
> > In this thread
> > <https://lists.apache.org/thread/2l50swqd1dymf2qjgrb4wqrbmwjtj02f> we've
> > discussed possible approaches to using null-related annotations. As the
> > result, the following approaches were proposed:
> >
> > 1. Use both @Nullable and @NotNull annotations everywhere;
> > 2. Use only @Nullable;
> > 3. Use only @NotNull;
> > 4. Do not use* @*Nullable nor @NotNull.
> >
> > I would like to propose a vote: please post the corresponding number of the
> > option you like. The voting will commence on Thursday, January 20 at 11:00
> > UTC.
> >
> > --
> > With regards,
> > Aleksandr Polovtcev
> >
Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3
Posted by Sergey <ma...@gmail.com>.
+1 for option2 (only @Nullable)
Best regards,
Sergey Kosarev.
чт, 13 янв. 2022 г. в 13:25, Alexander Polovtcev <al...@gmail.com>:
> Dear Igniters,
>
> In this thread
> <https://lists.apache.org/thread/2l50swqd1dymf2qjgrb4wqrbmwjtj02f> we've
> discussed possible approaches to using null-related annotations. As the
> result, the following approaches were proposed:
>
> 1. Use both @Nullable and @NotNull annotations everywhere;
> 2. Use only @Nullable;
> 3. Use only @NotNull;
> 4. Do not use* @*Nullable nor @NotNull.
>
> I would like to propose a vote: please post the corresponding number of the
> option you like. The voting will commence on Thursday, January 20 at 11:00
> UTC.
>
> --
> With regards,
> Aleksandr Polovtcev
>
Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3
Posted by Vladislav Pyatkov <vl...@gmail.com>.
I am sure the shorter, the better.
+1 to option 4.
On Thu, Jan 13, 2022 at 2:06 PM ткаленко кирилл <tk...@yandex.ru>
wrote:
> +1 to option 2
>
--
Vladislav Pyatkov
Re:[VOTE] @Nullable/@NotNull annotation usage in Ignite 3
Posted by ткаленко кирилл <tk...@yandex.ru>.
+1 to option 2
Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3
Posted by Vladimir Steshin <vl...@gmail.com>.
+1 for option 2
13.01.2022 13:25, Alexander Polovtcev пишет:
> Dear Igniters,
>
> In this thread
> <https://lists.apache.org/thread/2l50swqd1dymf2qjgrb4wqrbmwjtj02f> we've
> discussed possible approaches to using null-related annotations. As the
> result, the following approaches were proposed:
>
> 1. Use both @Nullable and @NotNull annotations everywhere;
> 2. Use only @Nullable;
> 3. Use only @NotNull;
> 4. Do not use* @*Nullable nor @NotNull.
>
> I would like to propose a vote: please post the corresponding number of the
> option you like. The voting will commence on Thursday, January 20 at 11:00
> UTC.
>
Re: [VOTE] @Nullable/@NotNull annotation usage in Ignite 3
Posted by Alexander Polovtcev <al...@gmail.com>.
+1 to option 2
On Thu, Jan 13, 2022 at 1:25 PM Alexander Polovtcev <al...@gmail.com>
wrote:
> Dear Igniters,
>
> In this thread
> <https://lists.apache.org/thread/2l50swqd1dymf2qjgrb4wqrbmwjtj02f> we've
> discussed possible approaches to using null-related annotations. As the
> result, the following approaches were proposed:
>
> 1. Use both @Nullable and @NotNull annotations everywhere;
> 2. Use only @Nullable;
> 3. Use only @NotNull;
> 4. Do not use* @*Nullable nor @NotNull.
>
> I would like to propose a vote: please post the corresponding number of
> the option you like. The voting will commence on Thursday, January 20 at
> 11:00 UTC.
>
> --
> With regards,
> Aleksandr Polovtcev
>
--
With regards,
Aleksandr Polovtcev