[GitHub] upthewaterspout commented on a change in pull request #21: GEODE-6172: Configure geode properties for benchmarks

[GitBox <gi...@apache.org>]

upthewaterspout commented on a change in pull request #21: GEODE-6172: Configure geode properties for benchmarks
URL: https://github.com/apache/geode-benchmarks/pull/21#discussion_r240736378
 
 

 ##########
 File path: geode-benchmarks/src/main/java/org/apache/geode/benchmark/parameters/GeodeProperties.java
 ##########
 @@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.benchmark.parameters;
+
+import java.util.Properties;
+
+import org.apache.geode.distributed.ConfigurationProperties;
+
+public class GeodeProperties {
+  public static Properties serverProperties() {
+    Properties serverProperties = new Properties();
 
 Review comment:
   We definitely don't configure the same properties on the client - but I guess we probably want some of these - like enabling time stats. I'll look into creating separate serverProperties(), clientProperties(), and locatorProperties() methods.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services