You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashutosh Chauhan <ha...@apache.org> on 2018/02/07 01:58:53 UTC
Re: Review Request 65422: HIVE-17626
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65422/#review196950
-----------------------------------------------------------
First pass review.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 3689 (patched)
<https://reviews.apache.org/r/65422/#comment276939>
Default should be reoptimize.
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 3691 (patched)
<https://reviews.apache.org/r/65422/#comment276940>
Instead of config this should be explain modifier. WE already have explain rewrite select .. We similarly can add explain reoptimize select ...
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 5066 (patched)
<https://reviews.apache.org/r/65422/#comment276964>
Instead of iterating over _this_ which can be very large, more efficient is to iterate on other list.
ql/src/java/org/apache/hadoop/hive/ql/AbstractReExecDriver.java
Lines 36 (patched)
<https://reviews.apache.org/r/65422/#comment276962>
Comments on what this driver does?
ql/src/java/org/apache/hadoop/hive/ql/AbstractReExecDriver.java
Lines 127 (patched)
<https://reviews.apache.org/r/65422/#comment276958>
Currently its only reexcuted once. Alternatively, we can keep re-running it if it fails again. e.g. in case of OOM, its possible that there are many joins which are mis-planed, but we get stats only for first join.
To avoid, very large number of retrials we can limit to some max attempts.
ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java
Lines 21 (patched)
<https://reviews.apache.org/r/65422/#comment276959>
Incorrect import ?
ql/src/java/org/apache/hadoop/hive/ql/ReExecOverlayDriver.java
Lines 25 (patched)
<https://reviews.apache.org/r/65422/#comment276961>
Add comments on what this Driver does.
ql/src/java/org/apache/hadoop/hive/ql/ReOptimizeDriver.java
Lines 29 (patched)
<https://reviews.apache.org/r/65422/#comment276963>
java class docs.
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java
Lines 4748-4749 (patched)
<https://reviews.apache.org/r/65422/#comment276968>
To avoid this we should switch to find equivalence of 2 operators based on their signature. e.g., Operator::logicalEquals().
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java
Lines 2364 (patched)
<https://reviews.apache.org/r/65422/#comment276965>
This should extend to all operators.
ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapper.java
Lines 33 (patched)
<https://reviews.apache.org/r/65422/#comment276966>
javadoc
ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/refs/OperatorRef.java
Lines 32 (patched)
<https://reviews.apache.org/r/65422/#comment276969>
Operator::logicalEquals() ?
ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/refs/OperatorRef.java
Lines 50 (patched)
<https://reviews.apache.org/r/65422/#comment276967>
Instead of relying on ids, better is to use (and extend) logic in SharedWorkOptimizer::compareOperator() ?
ql/src/java/org/apache/hadoop/hive/ql/stats/OperatorStatsReaderHook.java
Lines 56 (patched)
<https://reviews.apache.org/r/65422/#comment276970>
LOG.debug
- Ashutosh Chauhan
On Jan. 30, 2018, 6:13 p.m., Zoltan Haindrich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65422/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2018, 6:13 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> preview
>
>
> Diffs
> -----
>
> cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java a78e0c63d7
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b7d3e99e1a
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatCli.java ad31287879
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatDriver.java 533f0bcd6f
> itests/src/test/resources/testconfiguration.properties d86ff58840
> ql/src/java/org/apache/hadoop/hive/ql/AbstractReExecDriver.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/Context.java 820fbf0f58
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 74595b00f9
> ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java 49d2bf5f33
> ql/src/java/org/apache/hadoop/hive/ql/IDriver.java 6280be0b08
> ql/src/java/org/apache/hadoop/hive/ql/ReExecOverlayDriver.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ReOptimizeDriver.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 76e85636d1
> ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 199b181290
> ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 395a5f450f
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java 8dd7cfe58c
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkEmptyKeyOperator.java 134fc0ff0b
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkObjectHashOperator.java 1eb72ce4d9
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkUniformHashOperator.java 384bd74686
> ql/src/java/org/apache/hadoop/hive/ql/hooks/PrivateHookContext.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java cbadfa4f07
> ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 0057f0c2c6
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/EmptyStatsSource.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/GroupTransformer.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapper.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapperProcess.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/RuntimeStatsSource.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/SimpleRuntimeStatsSource.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/StatsSource.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/refs/OperatorRef.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java dcf8d31eaf
> ql/src/java/org/apache/hadoop/hive/ql/stats/OperatorStats.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/stats/OperatorStatsReaderHook.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrueOOM.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java d56002d192
> ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestCounterMapping.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestReOptimization.java PRE-CREATION
> ql/src/test/queries/clientpositive/retry_failure.q PRE-CREATION
> ql/src/test/queries/clientpositive/retry_failure_oom.q PRE-CREATION
> ql/src/test/queries/clientpositive/retry_failure_stat_changes.q PRE-CREATION
> ql/src/test/results/clientpositive/llap/retry_failure.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/retry_failure_oom.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/retry_failure_stat_changes.q.out PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65422/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zoltan Haindrich
>
>
Re: Review Request 65422: HIVE-17626
Posted by Zoltan Haindrich <ki...@rxd.hu>.
> On Feb. 7, 2018, 1:58 a.m., Ashutosh Chauhan wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> > Lines 3691 (patched)
> > <https://reviews.apache.org/r/65422/diff/1/?file=1950474#file1950474line3696>
> >
> > Instead of config this should be explain modifier. WE already have explain rewrite select .. We similarly can add explain reoptimize select ...
yes...I agree; it turned out that its very inconvinient to use it this way...
I've employed a semanticAnlayzer hook to handle the reoptimize keyword
> On Feb. 7, 2018, 1:58 a.m., Ashutosh Chauhan wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> > Lines 5066 (patched)
> > <https://reviews.apache.org/r/65422/diff/1/?file=1950474#file1950474line5071>
> >
> > Instead of iterating over _this_ which can be very large, more efficient is to iterate on other list.
I wasn't aware that the iterator() creates a new map on the fly....I'm now using getProps() to get access to the actual values
> On Feb. 7, 2018, 1:58 a.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/AbstractReExecDriver.java
> > Lines 127 (patched)
> > <https://reviews.apache.org/r/65422/diff/1/?file=1950478#file1950478line127>
> >
> > Currently its only reexcuted once. Alternatively, we can keep re-running it if it fails again. e.g. in case of OOM, its possible that there are many joins which are mis-planed, but we get stats only for first join.
> > To avoid, very large number of retrials we can limit to some max attempts.
I aggree
> On Feb. 7, 2018, 1:58 a.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java
> > Lines 21 (patched)
> > <https://reviews.apache.org/r/65422/diff/1/?file=1950481#file1950481line21>
> >
> > Incorrect import ?
I've just taken a look at null analysis; but it detects too many issues to just turn on...so I'll remove it for now :)
> On Feb. 7, 2018, 1:58 a.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/refs/OperatorRef.java
> > Lines 50 (patched)
> > <https://reviews.apache.org/r/65422/diff/1/?file=1950503#file1950503line50>
> >
> > Instead of relying on ids, better is to use (and extend) logic in SharedWorkOptimizer::compareOperator() ?
t
- Zoltan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65422/#review196950
-----------------------------------------------------------
On Jan. 30, 2018, 6:13 p.m., Zoltan Haindrich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65422/
> -----------------------------------------------------------
>
> (Updated Jan. 30, 2018, 6:13 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> preview
>
>
> Diffs
> -----
>
> cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java a78e0c63d7
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java b7d3e99e1a
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatCli.java ad31287879
> hcatalog/core/src/main/java/org/apache/hive/hcatalog/cli/HCatDriver.java 533f0bcd6f
> itests/src/test/resources/testconfiguration.properties d86ff58840
> ql/src/java/org/apache/hadoop/hive/ql/AbstractReExecDriver.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/Context.java 820fbf0f58
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 74595b00f9
> ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java 49d2bf5f33
> ql/src/java/org/apache/hadoop/hive/ql/IDriver.java 6280be0b08
> ql/src/java/org/apache/hadoop/hive/ql/ReExecOverlayDriver.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ReOptimizeDriver.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 76e85636d1
> ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 199b181290
> ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 395a5f450f
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java 8dd7cfe58c
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkEmptyKeyOperator.java 134fc0ff0b
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkObjectHashOperator.java 1eb72ce4d9
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkUniformHashOperator.java 384bd74686
> ql/src/java/org/apache/hadoop/hive/ql/hooks/PrivateHookContext.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 190771ea6b
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java cbadfa4f07
> ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 0057f0c2c6
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/EmptyStatsSource.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/GroupTransformer.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapper.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapperProcess.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/RuntimeStatsSource.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/SimpleRuntimeStatsSource.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/StatsSource.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/refs/OperatorRef.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/processors/CommandProcessorFactory.java dcf8d31eaf
> ql/src/java/org/apache/hadoop/hive/ql/stats/OperatorStats.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/stats/OperatorStatsReaderHook.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrueOOM.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDTFGetSplits.java d56002d192
> ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestCounterMapping.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestReOptimization.java PRE-CREATION
> ql/src/test/queries/clientpositive/retry_failure.q PRE-CREATION
> ql/src/test/queries/clientpositive/retry_failure_oom.q PRE-CREATION
> ql/src/test/queries/clientpositive/retry_failure_stat_changes.q PRE-CREATION
> ql/src/test/results/clientpositive/llap/retry_failure.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/retry_failure_oom.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/retry_failure_stat_changes.q.out PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/65422/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zoltan Haindrich
>
>
Re: Review Request 65422: HIVE-17626
Posted by Zoltan Haindrich <ki...@rxd.hu>.
> On Feb. 7, 2018, 1:58 a.m., Ashutosh Chauhan wrote:
> > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> > Lines 3689 (patched)
> > <https://reviews.apache.org/r/65422/diff/1/?file=1950474#file1950474line3694>
> >
> > Default should be reoptimize.
ok; but disabled it in all the other conf-s for now
> On Feb. 7, 2018, 1:58 a.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/AbstractReExecDriver.java
> > Lines 36 (patched)
> > <https://reviews.apache.org/r/65422/diff/1/?file=1950478#file1950478line36>
> >
> > Comments on what this driver does?
I've added an apidoc; but I feel more and more that this should be probably re-thinked - and instead of using an abstract type; the re-execution parts could be "pluggable" ; which could enable more than 1 at a time ... this would be trivial after finishing this; currently I feel that the patch keeps some questions open elsewhere.
> On Feb. 7, 2018, 1:58 a.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java
> > Lines 4748-4749 (patched)
> > <https://reviews.apache.org/r/65422/diff/1/?file=1950493#file1950493line4748>
> >
> > To avoid this we should switch to find equivalence of 2 operators based on their signature. e.g., Operator::logicalEquals().
removed from here
- Zoltan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65422/#review196950
-----------------------------------------------------------
On Feb. 26, 2018, 6:19 p.m., Zoltan Haindrich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65422/
> -----------------------------------------------------------
>
> (Updated Feb. 26, 2018, 6:19 p.m.)
>
>
> Review request for hive and Ashutosh Chauhan.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> preview
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 0880a960e6
> data/conf/llap/hive-site.xml c4c299c5de
> itests/src/test/resources/testconfiguration.properties 2776fe95f1
> itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java 6cd7a136ae
> ql/src/java/org/apache/hadoop/hive/ql/AbstractReExecDriver.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/Context.java dba2dbb15b
> ql/src/java/org/apache/hadoop/hive/ql/Driver.java 94999fed93
> ql/src/java/org/apache/hadoop/hive/ql/DriverFactory.java 60e8de8fd4
> ql/src/java/org/apache/hadoop/hive/ql/HookRunner.java 2a32a51588
> ql/src/java/org/apache/hadoop/hive/ql/IDriver.java 9f13fa8e88
> ql/src/java/org/apache/hadoop/hive/ql/ReExecOverlayDriver.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/ReOptimizeDriver.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 32fc257b03
> ql/src/java/org/apache/hadoop/hive/ql/exec/Operator.java 199b181290
> ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 395a5f450f
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkCommonOperator.java 8dd7cfe58c
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkEmptyKeyOperator.java 134fc0ff0b
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkObjectHashOperator.java 1eb72ce4d9
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/reducesink/VectorReduceSinkUniformHashOperator.java 384bd74686
> ql/src/java/org/apache/hadoop/hive/ql/hooks/PrivateHookContext.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/SharedWorkOptimizer.java b0cf3bd94e
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java 783a672c47
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java 9a3f81c98f
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g 78cbf25c43
> ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 733ec79ce1
> ql/src/java/org/apache/hadoop/hive/ql/parse/TezCompiler.java f9a6386ecf
> ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java 0057f0c2c6
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/EmptyStatsSource.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/GroupTransformer.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapper.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/PlanMapperProcess.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/RuntimeStatsSource.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/SimpleRuntimeStatsSource.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/StatsSource.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/plan/mapper/refs/OperatorRef.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/stats/OperatorStats.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/stats/OperatorStatsReaderHook.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFAssertTrueOOM.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/exec/vector/TestVectorGroupByOperator.java fa3f89fda1
> ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestCounterMapping.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestOperatorCmp.java PRE-CREATION
> ql/src/test/org/apache/hadoop/hive/ql/plan/mapping/TestReOptimization.java PRE-CREATION
> ql/src/test/queries/clientpositive/retry_failure.q PRE-CREATION
> ql/src/test/queries/clientpositive/retry_failure_oom.q PRE-CREATION
> ql/src/test/queries/clientpositive/retry_failure_stat_changes.q PRE-CREATION
> ql/src/test/results/clientpositive/llap/dp_counter_mm.q.out 869916078b
> ql/src/test/results/clientpositive/llap/dp_counter_non_mm.q.out 9f6426ccd1
> ql/src/test/results/clientpositive/llap/dynamic_semijoin_reduction_2.q.out cab45c9410
> ql/src/test/results/clientpositive/llap/explainuser_1.q.out 43ca0d9ad7
> ql/src/test/results/clientpositive/llap/join32_lessSize.q.out 5b5be13702
> ql/src/test/results/clientpositive/llap/join46.q.out 4625b9fed8
> ql/src/test/results/clientpositive/llap/limit_join_transpose.q.out 4dd7432ac5
> ql/src/test/results/clientpositive/llap/llap_partitioned.q.out ac754674ea
> ql/src/test/results/clientpositive/llap/mapjoin46.q.out f530c1e8e1
> ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out aa2dcc7f68
> ql/src/test/results/clientpositive/llap/orc_llap_counters1.q.out eb54a81d1a
> ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out 590437c708
> ql/src/test/results/clientpositive/llap/orc_ppd_schema_evol_3a.q.out c7c8993d0e
> ql/src/test/results/clientpositive/llap/retry_failure.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/retry_failure_oom.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/retry_failure_stat_changes.q.out PRE-CREATION
> ql/src/test/results/clientpositive/llap/semijoin_hint.q.out cdfa73349b
> ql/src/test/results/clientpositive/llap/subquery_in_having.q.out cc0b6a597a
> ql/src/test/results/clientpositive/llap/subquery_multi.q.out 67a22c812f
> ql/src/test/results/clientpositive/llap/subquery_notin.q.out 50c18c8a68
> ql/src/test/results/clientpositive/llap/subquery_scalar.q.out cec3daa085
> ql/src/test/results/clientpositive/llap/subquery_select.q.out 89eab37d07
> ql/src/test/results/clientpositive/llap/tez_join_tests.q.out 75879fb157
> ql/src/test/results/clientpositive/llap/tez_joins_explain.q.out 3790b37760
> ql/src/test/results/clientpositive/llap/vector_reduce_groupby_duplicate_cols.q.out 07c1e4188c
> ql/src/test/results/clientpositive/perf/tez/query72.q.out 55ddd5a0f8
> ql/src/test/results/clientpositive/perf/tez/query78.q.out 9c2d7b3491
> ql/src/test/results/clientpositive/show_functions.q.out 4e8ceaf6af
>
>
> Diff: https://reviews.apache.org/r/65422/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zoltan Haindrich
>
>