[GitHub] [calcite] zabetak commented on a change in pull request #1092: [CALCITE-2899] Deprecate RelTraitPropagationVisitor and remove its usages

[GitBox <gi...@apache.org>]

zabetak commented on a change in pull request #1092: [CALCITE-2899] Deprecate RelTraitPropagationVisitor and remove its usages
URL: https://github.com/apache/calcite/pull/1092#discussion_r263263171
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/plan/RelTraitPropagationVisitor.java
 ##########
 @@ -25,7 +25,19 @@
  * children, making sure that each has a full complement of traits. When a
  * RelNode is found to be missing one or more traits, they are copied from a
  * RelTraitSet given during construction.
+ *
+ * @deprecated As of 1.19, if you need to perform certain assertions regarding a RelNode tree and
+ * the contained traits you are encouraged to implement your own RelVisitor or
+ * {@link org.apache.calcite.rel.RelShuttle} directly. The reasons for deprecating this class are
+ * the following:
+ * <ul>
+ *   <li>The contract (Javadoc & naming) and the behavior of the class are inconsistent.</li>
 
 Review comment:
   Thanks for catching this @michaelmior ! 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services