You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Michael Park <mc...@gmail.com> on 2015/06/23 09:07:23 UTC
Review Request 35770: Consistent 'Test' suffix in mesos test names.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35770/
-----------------------------------------------------------
Review request for mesos, Ben Mahler and Till Toenshoff.
Repository: mesos
Description
-------
Follow-up from [r35697](https://reviews.apache.org/r/35697/).
Diffs
-----
src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
src/tests/cram_md5_authentication_tests.cpp 0a03846880473f53a367b01dcf4b66d33512a14b
src/tests/zookeeper_url_tests.cpp 86e6f5a57bb029202a12aff7bbf1d69018bf0579
Diff: https://reviews.apache.org/r/35770/diff/
Testing
-------
`make check`
Thanks,
Michael Park
Re: Review Request 35770: Consistent 'Test' suffix in mesos test
names.
Posted by Isabel Jimenez <co...@isabeljimenez.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35770/#review89087
-----------------------------------------------------------
Ship it!
Ship It!
- Isabel Jimenez
On June 23, 2015, 1:21 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35770/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 1:21 p.m.)
>
>
> Review request for mesos, Ben Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Follow-up from [r35697](https://reviews.apache.org/r/35697/).
>
>
> Diffs
> -----
>
> src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
> src/tests/cram_md5_authentication_tests.cpp 0a03846880473f53a367b01dcf4b66d33512a14b
> src/tests/zookeeper_url_tests.cpp 86e6f5a57bb029202a12aff7bbf1d69018bf0579
>
> Diff: https://reviews.apache.org/r/35770/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35770: Consistent 'Test' suffix in mesos test
names.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35770/#review90543
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On June 23, 2015, 1:21 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35770/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 1:21 p.m.)
>
>
> Review request for mesos, Ben Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Follow-up from [r35697](https://reviews.apache.org/r/35697/).
>
>
> Diffs
> -----
>
> src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
> src/tests/cram_md5_authentication_tests.cpp 0a03846880473f53a367b01dcf4b66d33512a14b
> src/tests/zookeeper_url_tests.cpp 86e6f5a57bb029202a12aff7bbf1d69018bf0579
>
> Diff: https://reviews.apache.org/r/35770/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35770: Consistent 'Test' suffix in mesos test
names.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35770/#review88986
-----------------------------------------------------------
Patch looks great!
Reviews applied: [35769, 35770]
All tests passed.
- Mesos ReviewBot
On June 23, 2015, 1:21 p.m., Michael Park wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35770/
> -----------------------------------------------------------
>
> (Updated June 23, 2015, 1:21 p.m.)
>
>
> Review request for mesos, Ben Mahler and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Follow-up from [r35697](https://reviews.apache.org/r/35697/).
>
>
> Diffs
> -----
>
> src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
> src/tests/cram_md5_authentication_tests.cpp 0a03846880473f53a367b01dcf4b66d33512a14b
> src/tests/zookeeper_url_tests.cpp 86e6f5a57bb029202a12aff7bbf1d69018bf0579
>
> Diff: https://reviews.apache.org/r/35770/diff/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Michael Park
>
>
Re: Review Request 35770: Consistent 'Test' suffix in mesos test
names.
Posted by Michael Park <mc...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35770/
-----------------------------------------------------------
(Updated June 23, 2015, 1:21 p.m.)
Review request for mesos, Ben Mahler and Till Toenshoff.
Changes
-------
Fixed error raised by ReviewBot. Turns out I wasn't getting this locally because I had set `--disable-java`.
Repository: mesos
Description
-------
Follow-up from [r35697](https://reviews.apache.org/r/35697/).
Diffs (updated)
-----
src/tests/common/http_tests.cpp 97a0eba896aa56acc244afbff83c155024aaedbf
src/tests/cram_md5_authentication_tests.cpp 0a03846880473f53a367b01dcf4b66d33512a14b
src/tests/zookeeper_url_tests.cpp 86e6f5a57bb029202a12aff7bbf1d69018bf0579
Diff: https://reviews.apache.org/r/35770/diff/
Testing
-------
`make check`
Thanks,
Michael Park