You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2016/05/09 17:23:23 UTC
Review Request 47125: RANGER-977: Ranger KMS default policies should
include hdfs & hive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47125/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
Bugs: Ranger-977
https://issues.apache.org/jira/browse/Ranger-977
Repository: ranger
Description
-------
Added support to include policy items for hdfs & hive users while creating default policy for KMS. Also added two new properties in ranger-admin-site.xml to read the values for hdfs & hive users during policy creation.
Also added a unit test case for creating ranger kms service.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java ab0798b
security-admin/src/main/resources/conf.dist/ranger-admin-site.xml e3f9f03
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java aaafde0
Diff: https://reviews.apache.org/r/47125/diff/
Testing
-------
1. Added unit test for creating ranger kms service.
2. Tested adding custom properties for hdfs & hive users in ranger-admin-site.xml from Ambari before installing ranger KMS service.
3. Tested by installing ranger KMS service with custom service accounts for hdfs & hive users as well as with default values.
Thanks,
Sailaja Polavarapu
Re: Review Request 47125: RANGER-977: Ranger KMS default policies
should include hdfs & hive
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47125/#review133882
-----------------------------------------------------------
Ship it!
Ship It!
- Velmurugan Periasamy
On May 18, 2016, 8:38 p.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47125/
> -----------------------------------------------------------
>
> (Updated May 18, 2016, 8:38 p.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: Ranger-977
> https://issues.apache.org/jira/browse/Ranger-977
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added support to include policy items for hdfs & hive users while creating default policy for KMS. Also added two new properties in ranger-admin-site.xml to read the values for hdfs & hive users during policy creation.
> Also added a unit test case for creating ranger kms service.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 69eb630
> security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 54bad58
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java aaafde0
>
> Diff: https://reviews.apache.org/r/47125/diff/
>
>
> Testing
> -------
>
> 1. Added unit test for creating ranger kms service.
> 2. Tested adding custom properties for hdfs & hive users in ranger-admin-site.xml from Ambari before installing ranger KMS service.
> 3. Tested by installing ranger KMS service with custom service accounts for hdfs & hive users as well as with default values.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 47125: RANGER-977: Ranger KMS default policies
should include hdfs & hive
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47125/
-----------------------------------------------------------
(Updated May 18, 2016, 8:38 p.m.)
Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
Changes
-------
Resolved the patch conflicts and updated the patch.
Bugs: Ranger-977
https://issues.apache.org/jira/browse/Ranger-977
Repository: ranger
Description
-------
Added support to include policy items for hdfs & hive users while creating default policy for KMS. Also added two new properties in ranger-admin-site.xml to read the values for hdfs & hive users during policy creation.
Also added a unit test case for creating ranger kms service.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 69eb630
security-admin/src/main/resources/conf.dist/ranger-admin-site.xml 54bad58
security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java aaafde0
Diff: https://reviews.apache.org/r/47125/diff/
Testing
-------
1. Added unit test for creating ranger kms service.
2. Tested adding custom properties for hdfs & hive users in ranger-admin-site.xml from Ambari before installing ranger KMS service.
3. Tested by installing ranger KMS service with custom service accounts for hdfs & hive users as well as with default values.
Thanks,
Sailaja Polavarapu
Re: Review Request 47125: RANGER-977: Ranger KMS default policies
should include hdfs & hive
Posted by Velmurugan Periasamy <vp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47125/#review133368
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java (line 2190)
<https://reviews.apache.org/r/47125/#comment197679>
@Sailaja - Patch failed to apply. Can you please check?
$ git apply --check -v < ~/Downloads/patches/ranger/0001-RANGER-977-Adding-hdfs-and-hive-policy-items-while-c.patch
Checking patch security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java...
Hunk #1 succeeded at 230 (offset 70 lines).
error: while searching for:
RangerServiceDefHelper serviceDefHelper = new RangerServiceDefHelper(serviceDef);
int i = 1;
for (List<RangerResourceDef> aHierarchy : serviceDefHelper.getResourceHierarchies(RangerPolicy.POLICY_TYPE_ACCESS)) {
createDefaultPolicy(createdService, vXUser, aHierarchy, i);
i++;
}
}
error: patch failed: security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java:2188
error: security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java: patch does not apply
Checking patch security-admin/src/main/resources/conf.dist/ranger-admin-site.xml...
error: while searching for:
<name>ranger.supportedcomponents</name>
<value></value>
</property>
</configuration>
error: patch failed: security-admin/src/main/resources/conf.dist/ranger-admin-site.xml:275
error: security-admin/src/main/resources/conf.dist/ranger-admin-site.xml: patch does not apply
Checking patch security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java...
- Velmurugan Periasamy
On May 9, 2016, 5:23 p.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47125/
> -----------------------------------------------------------
>
> (Updated May 9, 2016, 5:23 p.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: Ranger-977
> https://issues.apache.org/jira/browse/Ranger-977
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Added support to include policy items for hdfs & hive users while creating default policy for KMS. Also added two new properties in ranger-admin-site.xml to read the values for hdfs & hive users during policy creation.
> Also added a unit test case for creating ranger kms service.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java ab0798b
> security-admin/src/main/resources/conf.dist/ranger-admin-site.xml e3f9f03
> security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java aaafde0
>
> Diff: https://reviews.apache.org/r/47125/diff/
>
>
> Testing
> -------
>
> 1. Added unit test for creating ranger kms service.
> 2. Tested adding custom properties for hdfs & hive users in ranger-admin-site.xml from Ambari before installing ranger KMS service.
> 3. Tested by installing ranger KMS service with custom service accounts for hdfs & hive users as well as with default values.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>