You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2017/01/03 14:18:13 UTC
Re: Review Request 54638: Added agent flags '--oci_discovery' and
'--oci_discovery_prefix'.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54638/
-----------------------------------------------------------
(Updated Jan. 3, 2017, 10:18 p.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Added agent flags '--oci_discovery' and '--oci_discovery_prefix'.
Diffs (updated)
-----
docs/configuration.md e4beb2d5a72f1c5f59b2e40f4984cc60b8437d9d
src/slave/flags.hpp 6ac0d45072157f6741b96266886a326e9337c153
src/slave/flags.cpp 1eccea920338032173be4df6c374ec50dbd2eaf3
Diff: https://reviews.apache.org/r/54638/diff/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 54638: Added agent flags '--oci_discovery' and
'--oci_discovery_prefix'.
Posted by Jie Yu <yu...@gmail.com>.
> On Jan. 9, 2017, 9:11 a.m., Gilbert Song wrote:
> > src/slave/flags.cpp, line 173
> > <https://reviews.apache.org/r/54638/diff/2/?file=1596005#file1596005line173>
> >
> > What elas types we might have?
I would imaging 'registry' in the future
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54638/#review160874
-----------------------------------------------------------
On Feb. 1, 2017, 1:16 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54638/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 1:16 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added agent flags '--oci_discovery' and '--oci_discovery_prefix'.
>
>
> Diffs
> -----
>
> docs/configuration.md 6a30471d325f35e171e81a687c23fd69e9ec97ee
> src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505
> src/slave/flags.cpp b48678bae8b3f5bab62710043eaca14ab8370183
>
> Diff: https://reviews.apache.org/r/54638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 54638: Added agent flags '--oci_discovery' and
'--oci_discovery_prefix'.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54638/#review160874
-----------------------------------------------------------
src/slave/flags.hpp (lines 60 - 61)
<https://reviews.apache.org/r/54638/#comment232125>
As you may already observe, these two flags may be confusing. We may either find another name, or document them in the documentation patch later.
src/slave/flags.cpp (line 173)
<https://reviews.apache.org/r/54638/#comment232124>
What elas types we might have?
- Gilbert Song
On Jan. 3, 2017, 6:18 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54638/
> -----------------------------------------------------------
>
> (Updated Jan. 3, 2017, 6:18 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added agent flags '--oci_discovery' and '--oci_discovery_prefix'.
>
>
> Diffs
> -----
>
> docs/configuration.md e4beb2d5a72f1c5f59b2e40f4984cc60b8437d9d
> src/slave/flags.hpp 6ac0d45072157f6741b96266886a326e9337c153
> src/slave/flags.cpp 1eccea920338032173be4df6c374ec50dbd2eaf3
>
> Diff: https://reviews.apache.org/r/54638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 54638: Added agent flags '--oci_discovery' and
'--oci_discovery_prefix'.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54638/#review164296
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Feb. 1, 2017, 1:16 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54638/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2017, 1:16 a.m.)
>
>
> Review request for mesos, Gilbert Song and Jie Yu.
>
>
> Bugs: MESOS-6681
> https://issues.apache.org/jira/browse/MESOS-6681
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added agent flags '--oci_discovery' and '--oci_discovery_prefix'.
>
>
> Diffs
> -----
>
> docs/configuration.md 6a30471d325f35e171e81a687c23fd69e9ec97ee
> src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505
> src/slave/flags.cpp b48678bae8b3f5bab62710043eaca14ab8370183
>
> Diff: https://reviews.apache.org/r/54638/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 54638: Added agent flag '--oci_default_locator'.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54638/
-----------------------------------------------------------
(Updated March 30, 2017, 9:40 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Merged the flags `--oci_discovery` and `--oci_discovery_prefix` into `--oci_default_locator`.
Summary (updated)
-----------------
Added agent flag '--oci_default_locator'.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description (updated)
-------
Added agent flag '--oci_default_locator'.
Diffs (updated)
-----
docs/configuration.md 452478eab36f352a31f62f0c1f4da2f43f89bef9
include/mesos/type_utils.hpp 90b0227fd61d791e7bc791e6e68e11bf0f9ecac4
src/common/parse.hpp e90738a91161e26a48a6e381765e631492294641
src/common/type_utils.cpp 9d87a6d310a521f88cb744a9bd7e9f9a7b3d39c0
src/slave/flags.hpp 224fac1d06d5a3914d4d1408e880458ac5be010e
src/slave/flags.cpp 76881536e0058880f5720fbf3c1cebc684508235
Diff: https://reviews.apache.org/r/54638/diff/4/
Changes: https://reviews.apache.org/r/54638/diff/3-4/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 54638: Added agent flags '--oci_discovery' and
'--oci_discovery_prefix'.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54638/
-----------------------------------------------------------
(Updated Feb. 1, 2017, 9:16 a.m.)
Review request for mesos, Gilbert Song and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-6681
https://issues.apache.org/jira/browse/MESOS-6681
Repository: mesos
Description
-------
Added agent flags '--oci_discovery' and '--oci_discovery_prefix'.
Diffs (updated)
-----
docs/configuration.md 6a30471d325f35e171e81a687c23fd69e9ec97ee
src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505
src/slave/flags.cpp b48678bae8b3f5bab62710043eaca14ab8370183
Diff: https://reviews.apache.org/r/54638/diff/
Testing
-------
Thanks,
Qian Zhang