You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "jbonofre (via GitHub)" <gi...@apache.org> on 2026/05/28 15:19:26 UTC
[PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
jbonofre opened a new pull request, #38729:
URL: https://github.com/apache/beam/pull/38729
Bump activemq to 6.2.5 and qpid-jms-client to 2.10.0, both of which target jakarta.jms. Replace the geronimo-jms_2.0_spec dependency with jakarta.jms-api 3.1.0 and migrate all javax.jms imports and javadoc references in JmsIO main and test sources to jakarta.jms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-4925486134
Reminder, please take a look at this pr: @ahmedabu98 @damccorm @kennknowles
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #38729:
URL: https://github.com/apache/beam/pull/38729#discussion_r4213407448
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -689,6 +690,11 @@ class BeamModulePlugin implements Plugin<Project> {
activemq_junit : "org.apache.activemq.tooling:activemq-junit:$activemq_version",
activemq_kahadb_store : "org.apache.activemq:activemq-kahadb-store:$activemq_version",
activemq_mqtt : "org.apache.activemq:activemq-mqtt:$activemq_version",
+ activemq6_amqp : "org.apache.activemq:activemq-amqp:$activemq6_version",
Review Comment:
if activemq 5 and 6 have same package name, BeamModulePlugin version resolution doesn't work well as it tries to enforce a version it first see. As you may have already noticed and added force resolution in io.amqp
Consider simply bump activemq deps to v6 and pin to v5 in activemq, which has same effect
##########
.github/workflows/beam_PostCommit_Python_Xlang_Messaging_Direct.yml:
##########
@@ -69,6 +69,7 @@ jobs:
- name: Setup environment
uses: ./.github/actions/setup-environment-action
with:
+ java-version: '17'
Review Comment:
We no longer need these lines as the CI is on Java 21 currently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #38729:
URL: https://github.com/apache/beam/pull/38729#discussion_r4211317697
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -641,7 +641,7 @@ class BeamModulePlugin implements Plugin<Project> {
def protobuf_version = "4.33.2"
// TODO(https://github.com/apache/beam/issues/37637): Remove this once the Bom has been updated to at least reach this version
def bigtable_version = "2.73.1"
- def qpid_jms_client_version = "0.61.0"
+ def qpid_jms_client_version = "2.10.0"
Review Comment:
not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-4566896559
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-6044539267
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/38729?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 79.56%. Comparing base ([`69bdf5f`](https://app.codecov.io/gh/apache/beam/commit/69bdf5f29174adebe19006e1397acd6681ffce9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`e7961f1`](https://app.codecov.io/gh/apache/beam/commit/e7961f185a0e878cbc570d8d5b0268d3ffc066b9?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 41 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #38729 +/- ##
=============================================
+ Coverage 59.04% 79.56% +20.52%
=============================================
Files 2797 487 -2310
Lines 280750 82224 -198526
Branches 12488 0 -12488
=============================================
- Hits 165764 65421 -100343
+ Misses 108540 16803 -91737
+ Partials 6446 0 -6446
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/38729/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [go](https://app.codecov.io/gh/apache/beam/pull/38729/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [java](https://app.codecov.io/gh/apache/beam/pull/38729/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [python](https://app.codecov.io/gh/apache/beam/pull/38729/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `79.56% <ø> (-0.11%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/beam/pull/38729?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-5063079822
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-4773939661
Assigning reviewers:
R: @ahmedabu98 for label java.
R: @damccorm for label build.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on code in PR #38729:
URL: https://github.com/apache/beam/pull/38729#discussion_r3499497415
##########
sdks/java/io/mqtt/build.gradle:
##########
@@ -19,6 +19,19 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature( automaticModuleName: 'org.apache.beam.sdk.io.mqtt')
+// The JMS IO module pulls ActiveMQ 6.2.5 (Java 17) into the shared dependency
+// map. Because the global resolution strategy forces every mapped version,
+// that 6.2.5 would otherwise be forced onto this Java 11 module via the shared
+// org.apache.activemq coordinates. MQTT IO only needs ActiveMQ as an embedded
+// test broker, so pin it back to the Java 11-compatible 5.x line.
Review Comment:
I see a couple of mentions of making this compatible with Java 11, but then we're forcing Java 17 - do we actually need to force Java 17 or can we just require Java 11?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-5821255898
Hi @jbonofre, will you be rebasing soon? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-4857357790
Also, Jms used to have soem weird checkpointing behavior to accommondate Jms spec
> In JMS, acknowledging one message automatically acknowledges all messages processed by that specific session up to that point
This caused data loss due to Beam process and commit messages asynchronously. We ended up creating different sessions for each checkpointing: #30054
SInce this is a Jms spec upgrade, let me check if any breaking changes could happen especially checkpointing logics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-4969230397
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label java.
R: @liferoad for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #38729:
URL: https://github.com/apache/beam/pull/38729#discussion_r4219477035
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -689,6 +690,11 @@ class BeamModulePlugin implements Plugin<Project> {
activemq_junit : "org.apache.activemq.tooling:activemq-junit:$activemq_version",
activemq_kahadb_store : "org.apache.activemq:activemq-kahadb-store:$activemq_version",
activemq_mqtt : "org.apache.activemq:activemq-mqtt:$activemq_version",
+ activemq6_amqp : "org.apache.activemq:activemq-amqp:$activemq6_version",
Review Comment:
thanks, done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-5059339929
Updates: there will be significant changes in JmsIO (support ACKNOWLEDGE_MODE and Python xlang support) in next release. Current plan is to have one (or two) stable version before we moving to Java17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-4844609918
@damccorm the goal is to support the latest JMS spec version and so latest ActiveMQ version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-6049438803
R: @damccorm @Abacn
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #38729:
URL: https://github.com/apache/beam/pull/38729#discussion_r3502867463
##########
sdks/java/io/mqtt/build.gradle:
##########
@@ -19,6 +19,19 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature( automaticModuleName: 'org.apache.beam.sdk.io.mqtt')
+// The JMS IO module pulls ActiveMQ 6.2.5 (Java 17) into the shared dependency
+// map. Because the global resolution strategy forces every mapped version,
+// that 6.2.5 would otherwise be forced onto this Java 11 module via the shared
+// org.apache.activemq coordinates. MQTT IO only needs ActiveMQ as an embedded
+// test broker, so pin it back to the Java 11-compatible 5.x line.
Review Comment:
ActiveMQ is a test dependency for AmqpIO, MqttIO, JmsIO. Instead of modifying build.gradle in the former ones, can we just pin to ActiveMQ 6 in JmsIO? This should give a smaller diff and safer as it doesn't do a global upgrade.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #38729:
URL: https://github.com/apache/beam/pull/38729#discussion_r3502943937
##########
sdks/java/io/mqtt/build.gradle:
##########
@@ -19,6 +19,19 @@
plugins { id 'org.apache.beam.module' }
applyJavaNature( automaticModuleName: 'org.apache.beam.sdk.io.mqtt')
+// The JMS IO module pulls ActiveMQ 6.2.5 (Java 17) into the shared dependency
+// map. Because the global resolution strategy forces every mapped version,
+// that 6.2.5 would otherwise be forced onto this Java 11 module via the shared
+// org.apache.activemq coordinates. MQTT IO only needs ActiveMQ as an embedded
+// test broker, so pin it back to the Java 11-compatible 5.x line.
Review Comment:
PS: I'm thinking about we should move our Infra to Java17 (probably Java21, to reduce the frequency of this kind of upgrade) while keep Java11 compatibility via cross-compilation. We already use Java21 to publish Javadoc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-4565576905
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request modernizes the JmsIO module by migrating from the legacy javax.jms namespace to the Jakarta Messaging API (jakarta.jms). This change involves updating core dependencies to versions that support the Jakarta EE standard, ensuring compatibility with modern messaging infrastructure.
### Highlights
* **Dependency Upgrades**: Updated ActiveMQ to 6.2.5 and qpid-jms-client to 2.10.0 to support modern JMS standards.
* **Jakarta EE Migration**: Replaced the legacy geronimo-jms_2.0_spec with jakarta.jms-api 3.1.0 and migrated all javax.jms imports to jakarta.jms across the JmsIO module.
<details>
<summary><b>New Features</b></summary>
🧠 You can now enable **Memory** (public preview) to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-5063066095
R: @Abacn
R: @damccorm
also LGTM but leaving to you guy to confirm the comment thread is done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-4847285021
Sounds good - I'm good with the change pending the one open comment thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-5058512857
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @chamikaramj for label java.
R: @damccorm for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-5370177296
@damccorm I will rebase. I think this PR is good to go after rebase.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #38729:
URL: https://github.com/apache/beam/pull/38729#discussion_r4219252223
##########
.github/workflows/beam_PostCommit_Python_Xlang_Messaging_Direct.yml:
##########
@@ -69,6 +69,7 @@ jobs:
- name: Setup environment
uses: ./.github/actions/setup-environment-action
with:
+ java-version: '17'
Review Comment:
updated, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-5034135592
Reminder, please take a look at this pr: @Abacn @liferoad @kennknowles @ahmedabu98
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on code in PR #38729:
URL: https://github.com/apache/beam/pull/38729#discussion_r3318844147
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -597,7 +597,7 @@ class BeamModulePlugin implements Plugin<Project> {
//
// There are a few versions are determined by the BOMs by running scripts/tools/bomupgrader.py
// marked as [bomupgrader]. See the documentation of that script for detail.
- def activemq_version = "5.19.2"
+ def activemq_version = "6.2.5"
Review Comment:
ActiveMQ 6.x requires Java 17 as a minimum runtime version. Since Apache Beam still supports and runs tests on Java 8 and Java 11, upgrading `activemq_version` to `6.2.5` will cause test execution failures (such as `UnsupportedClassVersionError`) on Java 8 and Java 11 environments.
Please consider restricting the JmsIO tests to only run when the build JDK is 17 or higher, or verify how Java 8/11 compatibility will be maintained for the test suite.
##########
buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy:
##########
@@ -641,7 +641,7 @@ class BeamModulePlugin implements Plugin<Project> {
def protobuf_version = "4.33.2"
// TODO(https://github.com/apache/beam/issues/37637): Remove this once the Bom has been updated to at least reach this version
def bigtable_version = "2.73.1"
- def qpid_jms_client_version = "0.61.0"
+ def qpid_jms_client_version = "2.10.0"
Review Comment:
Qpid JMS Client 2.x requires Java 11 as a minimum runtime version. Since Apache Beam still supports Java 8, upgrading `qpid_jms_client_version` to `2.10.0` will break Java 8 compatibility for any users or tests utilizing this client. Please verify if this is intentional or if we need to restrict this dependency/module to Java 11+.
##########
sdks/java/io/jms/build.gradle:
##########
@@ -32,7 +32,7 @@ dependencies {
implementation project(path: ":sdks:java:core", configuration: "shadow")
implementation library.java.slf4j_api
implementation library.java.joda_time
- implementation "org.apache.geronimo.specs:geronimo-jms_2.0_spec:1.0-alpha-2"
+ implementation "jakarta.jms:jakarta.jms-api:3.1.0"
Review Comment:
`jakarta.jms:jakarta.jms-api:3.1.0` (Jakarta Messaging 3.1) is compiled for Java 11 (class file version 55.0). Since Apache Beam still supports Java 8, using version `3.1.0` will break Java 8 compatibility for the `beam-sdks-java-io-jms` module.
To maintain Java 8 compatibility while migrating to the `jakarta.jms` namespace, please use `jakarta.jms:jakarta.jms-api:3.0.0` (Jakarta Messaging 3.0), which is compiled for Java 8 (class file version 52.0).
```
implementation "jakarta.jms:jakarta.jms-api:3.0.0"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm commented on PR #38729:
URL: https://github.com/apache/beam/pull/38729#issuecomment-5370157899
@Abacn @jbonofre now that we're past the release cut, what are next steps? Should we clean this PR up and move forward with it or wait longer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #38729:
URL: https://github.com/apache/beam/pull/38729
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Update JmsIO to ActiveMQ 6.2.5 and jakarta.jms [beam]
Posted by "derrickaw (via GitHub)" <gi...@apache.org>.
derrickaw commented on code in PR #38729:
URL: https://github.com/apache/beam/pull/38729#discussion_r4211320341
##########
sdks/java/io/jms/build.gradle:
##########
@@ -32,7 +32,7 @@ dependencies {
implementation project(path: ":sdks:java:core", configuration: "shadow")
implementation library.java.slf4j_api
implementation library.java.joda_time
- implementation "org.apache.geronimo.specs:geronimo-jms_2.0_spec:1.0-alpha-2"
+ implementation "jakarta.jms:jakarta.jms-api:3.1.0"
Review Comment:
not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org