[GitHub] [hive] pvary commented on a change in pull request #818: HIVE-22298: Allow Llap IO cache for reading tables without delete delta

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #818: HIVE-22298: Allow Llap IO cache for reading tables without delete delta
URL: https://github.com/apache/hive/pull/818#discussion_r335615024
 
 

 ##########
 File path: llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java
 ##########
 @@ -182,10 +183,15 @@ private LlapRecordReader(MapWork mapWork, JobConf job, FileSplit split,
 
     this.isVectorized = HiveConf.getBoolVar(jobConf, HiveConf.ConfVars.HIVE_VECTORIZATION_ENABLED);
     if (isAcidScan) {
+      OrcSplit orcSplit = (OrcSplit) split;
       this.acidReader = new VectorizedOrcAcidRowBatchReader(
-          (OrcSplit) split, jobConf, Reporter.NULL, null, rbCtx, true);
+          orcSplit, jobConf, Reporter.NULL, null, rbCtx, true);
+      isAcidFormat = !orcSplit.isOriginal();
+    } else {
+      isAcidFormat = false;
     }
-    this.includes = new IncludesImpl(tableIncludedCols, isAcidScan, rbCtx,
+
+    this.includes = new IncludesImpl(tableIncludedCols, isAcidScan && isAcidFormat, rbCtx,
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org