You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@metron.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/10/19 08:22:00 UTC

[jira] [Commented] (METRON-1263) Start Alerts UI service after Metron REST

    [ https://issues.apache.org/jira/browse/METRON-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210720#comment-16210720 ] 

ASF GitHub Bot commented on METRON-1263:
----------------------------------------

GitHub user anandsubbu opened a pull request:

    https://github.com/apache/metron/pull/807

    METRON-1263: Start Alerts UI service after Metron REST

    ## Contributor Comments
    Currently the Alerts UI service starts up before any of the Metron services does. Ideally, it should be started after the Metron REST service. 
    
    The fix is to update role_command_order.json in the Ambari Mpack so that Alerts UI starts after Metron REST service. This commit also adds the other Alerts UI dependency to other service checks.
    
    **Steps to verify**
    - Build mpack and start Ambari wizard based installation
    - Verify that the Alerts UI service starts after the Metron REST service has started.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anandsubbu/incubator-metron METRON-1263

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/807.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #807
    
----
commit c2c54aa7a0bb47d7190e6e2e33489e33952d43d4
Author: Anand Subramanian <as...@hortonworks.com>
Date:   2017-10-19T08:04:08Z

    Update role_command_order to inlcude Alerts UI dependencies

----


> Start Alerts UI service after Metron REST
> -----------------------------------------
>
>                 Key: METRON-1263
>                 URL: https://issues.apache.org/jira/browse/METRON-1263
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Anand Subramanian
>            Assignee: Anand Subramanian
>
> The Metron Alerts UI service should be started after the Metron REST service has started, similar to the Metron Management UI service.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)