You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2008/12/05 20:40:46 UTC
[jira] Commented: (THRIFT-226) Collections with binary keys or
values break equals()
[ https://issues.apache.org/jira/browse/THRIFT-226?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12653907#action_12653907 ]
David Reiss commented on THRIFT-226:
------------------------------------
Ugh. This is going to significantly increase the complexity of both the generator and generated code.
> Collections with binary keys or values break equals()
> -----------------------------------------------------
>
> Key: THRIFT-226
> URL: https://issues.apache.org/jira/browse/THRIFT-226
> Project: Thrift
> Issue Type: Bug
> Components: Compiler (Java)
> Reporter: Bryan Duxbury
>
> In Java, byte[].equals tests object equality, not value equality. As a result, if you have two list<binary> (or set<binary>, or map<binary, binary> with the same values and you do TBase.equals(), two structs that match by value won't return true. If we're going to do value equality, which I think we should, then we should make this consistent with collection types.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.