You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Erzsebet Szilagyi <er...@gmail.com> on 2017/01/02 15:22:24 UTC
Re: Review Request 55001: Clean up expected exception logic in tests
- part I.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55001/#review160330
-----------------------------------------------------------
Ship it!
Thank you for improving our testing!
- Erzsebet Szilagyi
On Dec. 28, 2016, 4:57 p.m., Boglarka Egyed wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55001/
> -----------------------------------------------------------
>
> (Updated Dec. 28, 2016, 4:57 p.m.)
>
>
> Review request for Sqoop, Attila Szabo and Anna Szonyi.
>
>
> Bugs: SQOOP-3091
> https://issues.apache.org/jira/browse/SQOOP-3091
>
>
> Repository: sqoop-trunk
>
>
> Description
> -------
>
> Normalizing test cases where we except an exception using JUnit's ExpectedException rule to make the code mor clean and self-explanatory.
>
>
> Diffs
> -----
>
> src/test/com/cloudera/sqoop/TestAvroExport.java b51313895e8e5b5aa45aa7169b7200d50f53a792
> src/test/com/cloudera/sqoop/TestConnFactory.java 59c3455401c70acbac8a4d140639e611c03d30a5
> src/test/com/cloudera/sqoop/TestExportUpdate.java 95d7b6ae80c64ac4b6a574ada1d02e138d7c963a
> src/test/com/cloudera/sqoop/TestParquetExport.java c6ddef6a82e99c8b6c03e0d71584bed50b60355b
> src/test/com/cloudera/sqoop/TestSqoopOptions.java d95f904347191f84caa106a30a513978114eb5f0
> src/test/com/cloudera/sqoop/TestTargetDir.java 7aad7e15dcde092e0c674d5d818be9750d7347a6
> src/test/org/apache/sqoop/TestExportUsingProcedure.java cf5e2cd07ba3f322e53ebe9c3852eae13f78d133
>
> Diff: https://reviews.apache.org/r/55001/diff/
>
>
> Testing
> -------
>
> ant test, ant clean test
>
>
> Thanks,
>
> Boglarka Egyed
>
>