You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/04/01 00:04:03 UTC
Re: Review Request 45546: Implemented status() method of "network/cni"
isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45546/#review126469
-----------------------------------------------------------
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp (lines 791 - 792)
<https://reviews.apache.org/r/45546/#comment189454>
hum, what about labels and groups in NetworkInfo? I think we should save a copy during launch/recover, and fill the missing ip if needed here.
- Jie Yu
On March 31, 2016, 2:55 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45546/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 2:55 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented status() method of "network/cni" isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 1c8e231813c0579b79681c5d18b1f799a727ead7
>
> Diff: https://reviews.apache.org/r/45546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 45546: Implemented status() method of "network/cni"
isolator.
Posted by Qian Zhang <zh...@cn.ibm.com>.
> On April 1, 2016, 6:04 a.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 791-792
> > <https://reviews.apache.org/r/45546/diff/1/?file=1320825#file1320825line791>
> >
> > hum, what about labels and groups in NetworkInfo? I think we should save a copy during launch/recover, and fill the missing ip if needed here.
Agree, will fix it soon.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45546/#review126469
-----------------------------------------------------------
On March 31, 2016, 10:55 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45546/
> -----------------------------------------------------------
>
> (Updated March 31, 2016, 10:55 p.m.)
>
>
> Review request for mesos, Avinash sridharan, Gilbert Song, and Jie Yu.
>
>
> Bugs: MESOS-4759
> https://issues.apache.org/jira/browse/MESOS-4759
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Implemented status() method of "network/cni" isolator.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 1c8e231813c0579b79681c5d18b1f799a727ead7
>
> Diff: https://reviews.apache.org/r/45546/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>