[jira] [Commented] (THRIFT-4379) Haxe "make check" requires "sleep 10" to complete

["Oleksii Prudkyi (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225499#comment-16225499 ] 

Oleksii Prudkyi commented on THRIFT-4379:
-----------------------------------------

Hi, 

The sleep was added to ensure the server is closed 

i.e. default testing approach :
timeout 20 {run server} &
{run client}
sleep 10 (wait till servers stopped, if not then next tests will run over incorrect server and returns wrong positives)

the same pattern is exists in csharp as well (and as I remember was used in many others places) 
test/csharp/Makefile.am

probably creating own test runner (or even employ haxe original unit tests) might be good solution , other way is keeping pid of 'server' process and explicitly kill it after test (but this might break on some systems - it's non-standard makefile feature) 


> Haxe "make check" requires "sleep 10" to complete
> -------------------------------------------------
>
>                 Key: THRIFT-4379
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4379
>             Project: Thrift
>          Issue Type: Bug
>          Components: Haxe - Library
>    Affects Versions: 0.10.0
>         Environment: docker ubuntu-xenial
>            Reporter: James E. King, III
>            Assignee: Oleksii Prudkyi
>            Priority: Minor
>
> If you fire up the ubuntu-xenial docker container and run {{build/docker/script/autotools.sh}}, it will run all the unit tests including haxe.  When the haxe tests run, they have a "sleep 10" at the end of each test.  Something is holding on to resources that it should not be following the conclusion of the unit tests in order to require this sleep to pass.  Please investigate why the sleep is there and whether it can be removed?  This adds 30 seconds to every build unnecessarily and worse is indicative of a logic error in the code.
> See test/haxe/Makefile.am - that is where the sleeps originate from.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)