modperl_callback() guessing revisited

[Geoffrey Young <ge...@modperlcookbook.org>]

hi all

in continuing the discussion from last week (or was it the week before) 
where we decided to fix the PL_sv_undef thing first then re-examine 
modperl_callback's second-guessing the return value of the Perl callback...

attached is a patch that fixes things to how I think they should work

--Geoff

Re: modperl_callback() guessing revisited

[Stas Bekman <st...@stason.org>]

Geoffrey Young wrote:
> hi all
> 
> in continuing the discussion from last week (or was it the week before) 
> where we decided to fix the PL_sv_undef thing first then re-examine 
> modperl_callback's second-guessing the return value of the Perl callback...
> 
> attached is a patch that fixes things to how I think they should work

> -
> -            /* assume OK for non-HTTP status codes and for 200 (HTTP_OK) */
> -            if (((status > 0) && (status < 100)) ||
> -                (status == 200) || (status > 600)) {
> -                status = OK;
> -            }

So we remove any second-guessing, and require an explicit return as discussed 
before. +1

__________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@stason.org http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org