You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@apache.org> on 2020/10/12 14:17:50 UTC
Review Request 72953: Made the offer constraints filter non-optional
inside the allocator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72953/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10177
https://issues.apache.org/jira/browse/MESOS-10177
Repository: mesos
Description
-------
Now that the master always constructs an offer constraints filter
for a framework (potentially a no-op one) and always passes this filter
into an allocator, storing the filter as an `Option` inside the
hierarchical allocator is no longer necessary.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp 4ec15b64167efd75437c8edf107b94a984fbc9f6
src/master/allocator/mesos/hierarchical.cpp 35264b9d866c9b95b76fccde5cf3b438e3bae160
Diff: https://reviews.apache.org/r/72953/diff/1/
Testing
-------
`make check`
Thanks,
Andrei Sekretenko
Re: Review Request 72953: Made the offer constraints filter
non-optional inside the allocator.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72953/#review222026
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Mahler
On Oct. 12, 2020, 2:17 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72953/
> -----------------------------------------------------------
>
> (Updated Oct. 12, 2020, 2:17 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10177
> https://issues.apache.org/jira/browse/MESOS-10177
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Now that the master always constructs an offer constraints filter
> for a framework (potentially a no-op one) and always passes this filter
> into an allocator, storing the filter as an `Option` inside the
> hierarchical allocator is no longer necessary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 4ec15b64167efd75437c8edf107b94a984fbc9f6
> src/master/allocator/mesos/hierarchical.cpp 35264b9d866c9b95b76fccde5cf3b438e3bae160
>
>
> Diff: https://reviews.apache.org/r/72953/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Andrei Sekretenko
>
>