You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2020/06/05 17:10:01 UTC

[maven-shared-resources] branch MSHARED-854 updated (540cdb0 -> 7a0da87)

This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a change to branch MSHARED-854
in repository https://gitbox.apache.org/repos/asf/maven-shared-resources.git.


 discard 540cdb0  [MSHARED-854] Remove cacheFile property from TreeWalker
     new d917f7f  [MSHARED-854] Remove cacheFile property from TreeWalker
     new 7a0da87  Update DTD location

This update added new revisions after undoing existing revisions.
That is to say, some revisions that were in the old version of the
branch are not in the new version.  This situation occurs
when a user --force pushes a change and generates a repository
containing something like this:

 * -- * -- B -- O -- O -- O   (540cdb0)
            \
             N -- N -- N   refs/heads/MSHARED-854 (7a0da87)

You should already have received notification emails for all of the O
revisions, and so the following emails describe only the N revisions
from the common base, B.

Any revisions marked "omit" are not gone; other references still
refer to them.  Any revisions marked "discard" are gone forever.

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 src/main/resources/config/maven_checks.xml | 32 +++++++++++++++---------------
 1 file changed, 16 insertions(+), 16 deletions(-)


[maven-shared-resources] 02/02: Update DTD location

Posted by sl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch MSHARED-854
in repository https://gitbox.apache.org/repos/asf/maven-shared-resources.git

commit 7a0da8747d6422248c8bbdc991ada66dd95862e6
Author: Sylwester Lachiewicz <sl...@apache.org>
AuthorDate: Fri Jun 5 19:09:21 2020 +0200

    Update DTD location
---
 src/main/resources/config/maven_checks.xml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/main/resources/config/maven_checks.xml b/src/main/resources/config/maven_checks.xml
index 5d22e13..f04a0c8 100644
--- a/src/main/resources/config/maven_checks.xml
+++ b/src/main/resources/config/maven_checks.xml
@@ -19,8 +19,8 @@ under the License.
 -->
 
 <!DOCTYPE module PUBLIC
-    "-//Puppy Crawl//DTD Check Configuration 1.2//EN"
-    "http://www.puppycrawl.com/dtds/configuration_1_2.dtd">
+    "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+    "https://checkstyle.org/dtds/configuration_1_3.dtd">
 
 <!--
   Checkstyle configuration that checks the Maven coding conventions from:


[maven-shared-resources] 01/02: [MSHARED-854] Remove cacheFile property from TreeWalker

Posted by sl...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

slachiewicz pushed a commit to branch MSHARED-854
in repository https://gitbox.apache.org/repos/asf/maven-shared-resources.git

commit d917f7f72713324b1500c53d89c506dc2b457fc9
Author: Sylwester Lachiewicz <sl...@apache.org>
AuthorDate: Fri Jun 5 17:39:36 2020 +0200

    [MSHARED-854] Remove cacheFile property from TreeWalker
    
    Requires Checkstyle 8.19+
---
 src/main/resources/config/maven_checks.xml | 30 ++++++++++++++----------------
 1 file changed, 14 insertions(+), 16 deletions(-)

diff --git a/src/main/resources/config/maven_checks.xml b/src/main/resources/config/maven_checks.xml
index fda20c4..5d22e13 100644
--- a/src/main/resources/config/maven_checks.xml
+++ b/src/main/resources/config/maven_checks.xml
@@ -58,9 +58,20 @@ under the License.
         <property name="message" value="Line has trailing spaces."/>
     </module>-->
 
-    <module name="TreeWalker">
+    <module name="LineLength">
+        <property name="max" value="120" />
+        <property name="ignorePattern" value="@version|@see|@todo|TODO"/>
+    </module>
+
+    <!-- Support CHECKSTYLE_OFF: regexp and CHECKSTYLE_ON: regexp comments to disable/enable some checks -->
+    <!-- see http://checkstyle.sourceforge.net/config.html#SuppressionCommentFilter -->
+    <module name="SuppressWithPlainTextCommentFilter">
+        <property name="offCommentFormat" value="CHECKSTYLE_OFF\: (.+)"/>
+        <property name="onCommentFormat" value="CHECKSTYLE_ON\: (.+)"/>
+        <property name="checkFormat" value="$1"/>
+    </module>
 
-        <property name="cacheFile" value="${checkstyle.cache.file}"/>
+    <module name="TreeWalker">
 
         <property name="tabWidth" value="4"/>
 
@@ -70,7 +81,7 @@ under the License.
 
         <!-- required for SuppressionCommentFilter -->
         <!-- see http://checkstyle.sourceforge.net/config.html#SuppressionCommentFilter -->
-        <module name="FileContentsHolder"/>
+        <!-- <module name="FileContentsHolder"/>   -->
 
         <module name="LeftCurly">
           <property name="option" value="nl"/>
@@ -80,11 +91,6 @@ under the License.
           <property name="option" value="alone"/>
         </module>
 
-        <module name="LineLength">
-          <property name="max" value="120" />
-          <property name="ignorePattern" value="@version|@see|@todo|TODO"/>
-        </module>
-
         <module name="MemberName" />
 
         <!-- Checks for Javadoc comments.                     -->
@@ -210,12 +216,4 @@ under the License.
     <!-- See http://checkstyle.sourceforge.net/config_misc.html#UniqueProperties -->
     <module name="UniqueProperties"/>
 
-    <!-- Support CHECKSTYLE_OFF: regexp and CHECKSTYLE_ON: regexp comments to disable/enable some checks -->
-    <!-- see http://checkstyle.sourceforge.net/config.html#SuppressionCommentFilter -->
-    <module name="SuppressionCommentFilter">
-        <property name="offCommentFormat" value="CHECKSTYLE_OFF\: (.+)"/>
-        <property name="onCommentFormat" value="CHECKSTYLE_ON\: (.+)"/>
-        <property name="checkFormat" value="$1"/>
-    </module>
-
 </module>