You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/03/21 08:45:24 UTC
[GitHub] [netbeans] jlahoda commented on a change in pull request #2037:
Ignore module-info.java if on jdk1.8 or earlier.
jlahoda commented on a change in pull request #2037: Ignore module-info.java if on jdk1.8 or earlier.
URL: https://github.com/apache/netbeans/pull/2037#discussion_r395974692
##########
File path: java/java.api.common/src/org/netbeans/modules/java/api/common/classpath/ModuleClassPaths.java
##########
@@ -786,6 +787,12 @@ private static boolean hasModuleInfo(@NonNull final File file) {
newModuleInfos.add(moduleInfo);
if (found == null) {
found = FileUtil.toFileObject(moduleInfo);
+ if (found != null) {
+ String sourceLevel = SourceLevelQuery.getSourceLevel(found);
+ if (sourceLevel != null && sourceLevel.startsWith("1.")) { //NOI18N
+ found = null;
Review comment:
I'll investigate the JDK 11 problem later. But I wonder if this change is needed at all? I mean - this is all in a section where system module are available, and the resulting ClassPath should be more or less reasonable even if the module-info is considered, shouldn't it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists