You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/05/11 13:35:48 UTC
[GitHub] [phoenix-queryserver] stoty opened a new pull request #62: PHOENIX-6464 Release python-phoenixdb 1.0.1
stoty opened a new pull request #62:
URL: https://github.com/apache/phoenix-queryserver/pull/62
update version and changelog
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] stoty closed pull request #62: PHOENIX-6464 Release python-phoenixdb 1.0.1
Posted by GitBox <gi...@apache.org>.
stoty closed pull request #62:
URL: https://github.com/apache/phoenix-queryserver/pull/62
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] stoty commented on a change in pull request #62: PHOENIX-6464 Release python-phoenixdb 1.0.1
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #62:
URL: https://github.com/apache/phoenix-queryserver/pull/62#discussion_r630392208
##########
File path: python-phoenixdb/NEWS.rst
##########
@@ -1,6 +1,12 @@
Changelog
=========
+Version 1.0.1
+-------------
+
+- Use HTTP sessions to enable sticky load balancers
+- Revert default GSSAPI OID to "1.3.6.1.5.5.2" to improve compatibility
Review comment:
This is manual. It's more like a release notes than a changelog file.
I have followed the existing format.
A quick google search suggests that this format is quite standard for python projects.
I will add the JIRAs in parentheses after the line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] virajjasani commented on a change in pull request #62: PHOENIX-6464 Release python-phoenixdb 1.0.1
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #62:
URL: https://github.com/apache/phoenix-queryserver/pull/62#discussion_r630348836
##########
File path: python-phoenixdb/NEWS.rst
##########
@@ -1,6 +1,12 @@
Changelog
=========
+Version 1.0.1
+-------------
+
+- Use HTTP sessions to enable sticky load balancers
+- Revert default GSSAPI OID to "1.3.6.1.5.5.2" to improve compatibility
Review comment:
Is this generated through some script or manually? If manually, can we also add Jira number?
I have not used `.rst` format so far, so I might be wrong about the convention followed :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] stoty commented on a change in pull request #62: PHOENIX-6464 Release python-phoenixdb 1.0.1
Posted by GitBox <gi...@apache.org>.
stoty commented on a change in pull request #62:
URL: https://github.com/apache/phoenix-queryserver/pull/62#discussion_r630408213
##########
File path: python-phoenixdb/NEWS.rst
##########
@@ -1,6 +1,12 @@
Changelog
=========
+Version 1.0.1
+-------------
+
+- Use HTTP sessions to enable sticky load balancers (PHOENIX-6459)
+- Revert default GSSAPI OID to "1.3.6.1.5.5.2" to improve compatibility (PHOENIX-6414)
Review comment:
Replaced.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [phoenix-queryserver] virajjasani commented on a change in pull request #62: PHOENIX-6464 Release python-phoenixdb 1.0.1
Posted by GitBox <gi...@apache.org>.
virajjasani commented on a change in pull request #62:
URL: https://github.com/apache/phoenix-queryserver/pull/62#discussion_r630398616
##########
File path: python-phoenixdb/NEWS.rst
##########
@@ -1,6 +1,12 @@
Changelog
=========
+Version 1.0.1
+-------------
+
+- Use HTTP sessions to enable sticky load balancers (PHOENIX-6459)
+- Revert default GSSAPI OID to "1.3.6.1.5.5.2" to improve compatibility (PHOENIX-6414)
Review comment:
nit: although this release note looks good, would you like to include `SPNEGO` in the statement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org