[GitHub] betodealmeida opened a new pull request #6933: Show charts and dashboards based also on database permissions

[GitBox <gi...@apache.org>]

betodealmeida opened a new pull request #6933: Show charts and dashboards based also on database permissions
URL: https://github.com/apache/incubator-superset/pull/6933
 
 
   Currently, if a user has permission access to a given database, say `db1`, they will not see charts or dashboards created with datasources from that database unless they also have explicit permission to the datasource. For example, if we have:
   
   1. A chart `chart1` created from a table `db1.table`;
   2. A dashboard `dash1` containing `chart1`;
   3. A user with permissions `database access on [db1].(id:2)`.
   
   Currently, the user will not see `chart1` in the list of charts, nor `dash1` in the list of dashboards.
   
   I fixed it by bringing additional permissions, joining chart to datasource to table to database. I tested by creating a new DB `db1`, and a new role that has permissions `[datasource access on [db1].(id:2), database access on [db1].(id:2)`. The user could see the chart and the dashboard correctly.
   
   @mistercrunch not sure if this was a bug, but when I added `db1` the permission-view `database access on [db1].(id:2)` was not automatically created (the permission `database_access` obviously existed, and the view menu `[db1].(id:2)` was created correctly). I had to manually add a row to `ab_permission_view` connecting them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org