You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "westonpace (via GitHub)" <gi...@apache.org> on 2023/04/17 17:23:34 UTC
[GitHub] [arrow] westonpace opened a new pull request, #35194: GH-35192: [Docs] Switch from `logo` to `logo_url` to support sphinx >= 6
westonpace opened a new pull request, #35194:
URL: https://github.com/apache/arrow/pull/35194
### Rationale for this change
Sphinx dropped support for the `logo` property in release 6. See https://github.com/sphinx-doc/sphinx/issues/11062 Instead we are supposed to use `logo_url` which has been available since release 4.
### What changes are included in this PR?
Change from `logo` to `logo_url`
### Are these changes tested?
There was a CI test that was failing so yes.
### Are there any user-facing changes?
No. We already required `sphinx >= 4` and since `logo_url` is available in 4 we should not need to update the minimum sphinx version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #35194: GH-35192: [Docs] Switch from `logo` to `logo_url` to support sphinx >= 6
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #35194:
URL: https://github.com/apache/arrow/pull/35194#issuecomment-1513380903
Validated that it works on the preview docs here: http://crossbow.voltrondata.com/pr_docs/35204/c_glib/index.html
```
<a class="navbar-brand" href="../index.html">
<img src="../_static/../_static/arrow.png" class="logo" alt="logo">
</a>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd merged pull request #35194: GH-35192: [Docs] Switch from `logo` to `logo_url` to support sphinx >= 6
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd merged PR #35194:
URL: https://github.com/apache/arrow/pull/35194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35194: GH-35192: [Docs] Switch from `logo` to `logo_url` to support sphinx >= 6
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35194:
URL: https://github.com/apache/arrow/pull/35194#issuecomment-1515775795
Benchmark runs are scheduled for baseline = 1deb740e02fa928e60ce611790d9dff2d1a6077e and contender = 00072f9f95b61ed58f5ffcb52fb8a1e0956dfa91. 00072f9f95b61ed58f5ffcb52fb8a1e0956dfa91 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/73018541042d4808a6600e0cbd941064...2ae0cb37571446938188f9db997bf48e/)
[Failed] [test-mac-arm](https://conbench.ursa.dev/compare/runs/068dddb20be048b0b054463e140c2917...df3c577409844c0fa69cac91613f92c1/)
[Finished :arrow_down:13.27% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9a08131ea23a49a5bf5f63355e5d7050...903a973916664f52bcced867d6ba44dd/)
[Finished :arrow_down:0.18% :arrow_up:0.0%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/adcce15e47534a55af077a02d287e697...197e4888adaf4cfd8b9b767154642144/)
Buildkite builds:
[Finished] [`00072f9f` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2742)
[Failed] [`00072f9f` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2776)
[Finished] [`00072f9f` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2740)
[Finished] [`00072f9f` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2767)
[Finished] [`1deb740e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2741)
[Failed] [`1deb740e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2775)
[Finished] [`1deb740e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/2739)
[Finished] [`1deb740e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2766)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35194: GH-35192: [Docs] Switch from `logo` to `logo_url` to support sphinx >= 6
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35194:
URL: https://github.com/apache/arrow/pull/35194#issuecomment-1511989544
Revision: c08d94a4b623810de0aa8768f7fe0ea2c2ca5f55
Submitted crossbow builds: [ursacomputing/crossbow @ actions-a255490ddc](https://github.com/ursacomputing/crossbow/branches/all?query=actions-a255490ddc)
|Task|Status|
|----|------|
|preview-docs|[](https://github.com/ursacomputing/crossbow/actions/runs/4725203490/jobs/8383313402)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35194: GH-35192: [Docs] Switch from `logo` to `logo_url` to support sphinx >= 6
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35194:
URL: https://github.com/apache/arrow/pull/35194#issuecomment-1511780281
* Closes: #35192
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #35194: GH-35192: [Docs] Switch from `logo` to `logo_url` to support sphinx >= 6
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #35194:
URL: https://github.com/apache/arrow/pull/35194#issuecomment-1515776394
['Python', 'R'] benchmarks have high level of regressions.
[ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/9a08131ea23a49a5bf5f63355e5d7050...903a973916664f52bcced867d6ba44dd/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #35194: GH-35192: [Docs] Switch from `logo` to `logo_url` to support sphinx >= 6
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #35194:
URL: https://github.com/apache/arrow/pull/35194#issuecomment-1512678661
Revision: c08d94a4b623810de0aa8768f7fe0ea2c2ca5f55
Submitted crossbow builds: [ursacomputing/crossbow @ actions-6dd0e5c7ff](https://github.com/ursacomputing/crossbow/branches/all?query=actions-6dd0e5c7ff)
|Task|Status|
|----|------|
|test-ubuntu-default-docs|[](https://github.com/ursacomputing/crossbow/runs/12825745526)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #35194: GH-35192: [Docs] Switch from `logo` to `logo_url` to support sphinx >= 6
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #35194:
URL: https://github.com/apache/arrow/pull/35194#issuecomment-1511986770
@github-actions crossbow submit preview-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] raulcd commented on pull request #35194: GH-35192: [Docs] Switch from `logo` to `logo_url` to support sphinx >= 6
Posted by "raulcd (via GitHub)" <gi...@apache.org>.
raulcd commented on PR #35194:
URL: https://github.com/apache/arrow/pull/35194#issuecomment-1512675467
@github-actions crossbow submit test-ubuntu-default-docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org